fix(deps): Align and integrity-check cdn resources in perf trials #918
+70
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
force-pushed
the
deps-perf-d3
branch
from
e87ce60
to
8c7d5d8
Compare
legobeat
changed the title
1 task
legobeat
changed the title
legobeat
force-pushed
the
deps-perf-d3
branch
7 times, most recently
from
3b3bd75
to
14c5c86
Compare
|
@kumavis pls help |
legobeat
force-pushed
the
deps-perf-d3
branch
5 times, most recently
from
1485edc
to
53d11c0
Compare
|
I'd approve this, but I'm still waiting for that CORS talk from @naugtur |
legobeat
force-pushed
the
deps-perf-d3
branch
from
53d11c0
to
9b5def2
Compare
1 task
legobeat
force-pushed
the
deps-perf-d3
branch
3 times, most recently
from
482056f
to
45052d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integrityandcrossoriginattributes to js and stylesheets loaded from external CDNc3 is unmaintained and if updating d3 for the perf trials further is actually desired, it would probably have to be replaced with something else, like
billboard.js