chore: re-enable no-undef rule for tests #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg:lavamoat-core
legobeat
reviewed
Jan 30, 2024
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable no-undef */ | |||
There was a problem hiding this comment.
Rather than entirely disabling the rule here, how about listing the globals actually used?
Suggested change
| /* eslint-disable no-undef */ | |
| /* global checkGlobal, checkSelf, checkThis, checkWindow */ |
There was a problem hiding this comment.
ahh, needs /* global someVar: write */: and then another no-undef disable above it 😄
There was a problem hiding this comment.
this is what made it work:
// eslint-disable-next-line no-unused-vars
/* global checkThis: true, checkSelf: true, checkWindow: true, checkGlobal: true */
legobeat
force-pushed
the
boneskull/no-undef
branch
from
a6e5b6e
to
84855d5
Compare
boneskull
force-pushed
the
boneskull/no-undef
branch
from
84855d5
to
c04d76c
Compare
github-actions
bot
added
the
pkg:@lavamoat/webpack
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @boneskull and the rest of your teammates on |
boneskull
force-pushed
the
boneskull/no-undef
branch
from
c04d76c
to
c2896da
Compare
boneskull
force-pushed
the
boneskull/no-undef
branch
from
c2896da
to
eca93ff
Compare
legobeat
approved these changes
Mar 12, 2024
|
I'm skeptical (as in, all undef warnings will be ignored anyway as we move forward, just with added manual labor) |
boneskull
force-pushed
the
boneskull/no-undef
branch
from
eca93ff
to
b483996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs #960 to pass CI, but I cannot target a branch in a fork.no-undefwas disabled because we use a lot of undefined variables, but it's better to create lint exceptions on a line-by-line or file-by-file basis, since it can cause the problem fixed in #960.