Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working for TypeScript 4.9? #168

Closed
stephenh opened this issue Nov 17, 2022 · 7 comments
Closed

Not working for TypeScript 4.9? #168

stephenh opened this issue Nov 17, 2022 · 7 comments
Labels
Awaiting Upstream Fix Bug-fix for dependency is in progress

Comments

@stephenh
Copy link

I'm upgrading our codebase to 4.9.3 and noticing that paths are not being rewritten anymore.

I can put together a reproduction, but just wondering before I do that if this is a known issue/others have seen it/etc.

Thanks!

@carlocorradini
Copy link
Contributor

@stephenh Same issue

@nonara
Copy link
Collaborator

nonara commented Nov 18, 2022

Hi all. Unfortunately, this is an issue in 4.9. There was a regression with visitEachChild, which most transformers rely on. There is a fix ready and it's marked for review. I had hoped it would make it in to 4.9.3, but it looks like it hasn't yet.

Here are the links so you can follow the issue & PRs

@nonara nonara added the Awaiting Upstream Fix Bug-fix for dependency is in progress label Nov 18, 2022
@bradennapier
Copy link
Contributor

The...wait...is...unbearable :-D good to know though, this should have been better communicated with the impact it had upon the ecosystem IMO. Glad it is already in the works - no pre-builds of 4.9.4 yet :(

@DanielRosenwasser
Copy link

4.9.4 is now out FWIW

@samchon
Copy link

samchon commented Dec 8, 2022

typescript-transform-paths does not work on TS 4.9.4

@nonara
Copy link
Collaborator

nonara commented Dec 9, 2022

Thanks to @DanielRosenwasser and the team for getting the fix through!

typescript-transform-paths does not work on TS 4.9.4

4.9.4 changes required changes to ttypescript and ts-patch. I investigated this and updated the methodology. The latest versions of tts and tsp now work with 4.9.4.

Having completed those updates, this library works. Simply make sure you're using the latest tts or tsp.

@carlocorradini
Copy link
Contributor

@nonara Awesome! Can we close this?

@nonara nonara closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Upstream Fix Bug-fix for dependency is in progress
Projects
None yet
Development

No branches or pull requests

6 participants