Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/upgrade packages #385

Merged
merged 6 commits into from Dec 2, 2022
Merged

Build/upgrade packages #385

merged 6 commits into from Dec 2, 2022

Conversation

evad1n
Copy link
Contributor

@evad1n evad1n commented Nov 30, 2022

Description

This PR upgrades many of the dev/build packages to their latest versions and reruns build scripts and linting.

Couldn't upgrade Typescript to latest (4.9.3) due to this issue which causes the transformer plugins to not work, so it was put to the next latest version 4.84.

Todo

  • Bump version and add tag

@evad1n evad1n self-assigned this Nov 30, 2022
@vercel
Copy link

vercel bot commented Nov 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
amino-ui ✅ Ready (Inspect) Visit Preview Dec 2, 2022 at 9:21PM (UTC)

@goodpickle
Copy link
Contributor

@Thienhuynh95 Will you take a look at this build changes in this one? You were the primary contributor to what has been changed.

@Thienhuynh95
Copy link
Contributor

Yes, I did look at them yesterday, but got distracted by the landed cost breakdown. I will review that in a minute. I planned to review that right after finishing up what I'm thinking for the landed cost breakdown.

Thienhuynh95
Thienhuynh95 previously approved these changes Dec 2, 2022
Copy link
Contributor

@Thienhuynh95 Thienhuynh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played with the dist folder in the dashboard, and auto import of component, icon, and flag works so far. This looks good to me. Well done on upgrading the package 💯

@evad1n evad1n merged commit 4a5a0ac into develop Dec 2, 2022
@evad1n evad1n deleted the build/upgrade-packages branch December 2, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants