Fix error if using shapeAt within line boundaries but outside of tolerance #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 12, 2018 11:24
Fixes an error which occurs in the delete-shape example upon ctrl+click within the bounding box of a path but outside of the tolerance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delete-shape example has been updated to show the error.
To recreate, remove the fix in Leaflet.Editable.js and then ctrl+click within the rectangular bounds of a line but outside of the click tolerance area.
Error would then be:
leaflet _projectLatlngs method expects that the latlngs supplied are only ever an array, not a LatLng object.