Fix tooltip focus listener if getElement is no function #8890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a LayerGroup contains other layers without the
getElement()
function (for example another layergroup), it will throw an error, because it loops over all layers in the LayerGroup:Leaflet/src/layer/Tooltip.js
Lines 388 to 395 in 9b9c712
Another solution (and I think the cleaner one) would be to loop over all layers and calling
_addFocusListeners
instead of_addFocusListenersOnLayer
. But I'm a little bit scared about endless recursion.This fix needs to be cherry-picked into
v1