LIVE-784 Sell and Fund flow #2232
Conversation
|
Is this supposed to still be a draft @JunichiSugiura ? If not, you have failing CI (unused imports and whatnot) and should fill all the description so I know what this is about 🙏🏼 |
| const exchangeAction = createAction(completeExchange); | ||
| const sendAction = txCreateAction(connectApp); | ||
|
|
||
| const styles = StyleSheet.create({ | ||
| root: { | ||
| flex: 1, | ||
| padding: 32, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Couldn't we move the definition of these variables before the declaration of the PlatformCompleteExchange function (l 23) to follow the no-use-before-define rule and therefore reduce confusion?
There was a problem hiding this comment.
To me the most important part of the file is its props and functional component and these should be defined at the top most. It's the same reason as defining styles in the bottom. If you think no-use-before-define rule is the best bet, then it should be forced by a linter. Forcing without linter would become unmanageable eventually.
| const action = createAction(connectApp, startExchange); | ||
|
|
||
| const styles = StyleSheet.create({ | ||
| root: { | ||
| flex: 1, | ||
| padding: 32, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Couldn't we move the definition of these variables before the declaration of the PlatformStartExchange function (l 18) to follow the no-use-before-define rule and therefore reduce confusion?
|
@JunichiSugiura FYI I updated the test plan section in the description to reference the platform-app-test-exchange app and add info regarding the test version of the nano |
Type
Feature
Context
LIVE-784
It's the same as LedgerHQ/ledger-live-desktop#4361 but for mobile.
Parts of the app affected / Test plan
PS: You will need a test version of the exchange app to test the fund flow, cf. the platform-app-test-exchange README for details.
.env
manifest.json
{ "id": "test-app", "name": "Test app", "url": "http://localhost:3000", "homepageUrl": "https://developers.ledger.com/", "icon": "", "platform": "all", "apiVersion": "0.0.1", "manifestVersion": "1", "branch": "debug", "categories": ["tools"], "currencies": "*", "content": { "shortDescription": { "en": "Test Live App. Use at your own risk." }, "description": { "en": "Test Live App. Use at your own risk." } }, "permissions": [ { "method": "*" } ], "domains": [ "https://*", "http://*" ] }fund-flow.mov