Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

bugfix/LIVE 823 llm modal after claiming rewards has placeholder text #2266

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LFBarreto
Copy link
Contributor

@LFBarreto LFBarreto commented Mar 4, 2022

  • fix(React Navigation Header): issue where headerTitle = null defaults to route name header title

header title issue regression during last react navigation upgrade

Before

Screenshot_2022-03-04-13-36-59-429_com ledger live debug

After

Screenshot_2022-03-04-13-34-50-971_com ledger live debug

Type

Bug Fix

Context

LIVE-823

Parts of the app affected / Test plan

Header for confirmation and error transaction flows

@LFBarreto LFBarreto requested review from a team as code owners March 4, 2022 12:36
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

Thanks for your contribution.
To be able to merge in develop branch, you need to:

  • pass the CI
  • if needed, run /generate-screenshots
  • have a dev review
  • have a QA review
  • if needed, /upgrade-llc

Why /generate-screenshots ?

If your PR contains UI related changes,
it might be necessary to regenerate screenshots.

Why /upgrade-llc ?

If your PR requires an update to the ledger-live-common library,
once the PR is merged on develop on ledger-live-common side,
you need to run /upgrade-llc to switch back to ledger-live-common@develop here before merging.

Copy link
Contributor

@juan-cortes juan-cortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants