Regions v3 regression, Intl polyfill #2332

ofreyssinet-ledger · 2022-03-24T15:25:26Z

Put region settings back in the general settings UI.
Reimplement of "searchable" list in makeGenericSelectScreen.tsx, this was a regression of v3 as it was implemented in the .js version already.
Fix regression in components using the incorrect locale (things that were implemented in V2 but not in V3 components), used this PR as a base LL-6732 regions, dates, time and currencies #1941.
Fix remaining incorrect uses of useLocale() when doing number/date formatting (instead, using localeSelector), see following point for explanation.
Rename useLocale() (in Locale.js) to useTranslationLocale() & document it to avoid confusions & uses in wrong context (it should be used only for handling translatable content, not for number & date formatting).
Ensure Intl polyfill (for Hermes) are imported and working for all selectable regions. (with a small patch to avoid this issue TypeError caused by wrong data format in intl-datetimeformat/locale-data/haw.js formatjs/formatjs#3503)
⚠️ DX is bad because importing all locale data at each reload takes very long
Need to revert this change in live-common LedgerHQ/ledger-live-common@6b9efb5 as it prevents formatting of currency (it would work without this change thanks to the polyfill)

Type

Bug fix

Context

Parts of the app affected / Test plan

… LL-7937

* Remove useless dependency to hw-app-btc * Also remove hw-app-eth and hw-app-xrp

… LL-7742

* Use design system for Checkbox and Swich components * Removed useless @flow marker on checkbox file

)

* Rebrand footer navigation * remove log

…precated (#1990)

… LL-7742

* LIVE-1667 Cosmos Select Amount to undelegate page updated * LL-1667 some cosmos transaction pages updated * LL-1667 SafeAreaView replaced with View in cosmos 01-Started.js

* LL-1669 some polkadot transaction pages updated * LL-1669 ClearNominations and Nominate pages improved and fixed * LL-1669 console log removed

* (V3): boosty perfs * enable hermes for ios and polyfill intl * remove obsolete jsc flags * (Onboarding): fixes for small screens + some other issues Co-authored-by: Julien Elbaz <elbywan@hotmail.com>

…overflow, resosurces bad urls) (#2323)

* remove unused * update margin top

using this diff as a reference https://github.com/LedgerHQ/ledger-live-mobile/pull/1941/files

That's because useLocale returns the language locale and not the locale used for number & date formatting (they are separated)

LFBarreto and others added 30 commits October 20, 2021 09:15

LL-7744 (V3): init branching setup

ca49ee4

install react navigation v6

0f63196

replace dangerouslyGetParent by getParent

9b99934

(Deeplink): update for v6 linking

ed5695e

Merge branch 'LL-7937' of github.com:LedgerHQ/ledger-live-mobile into…

0cbdac1

… LL-7937

replace mode="modal" with new api

fea7923

Merge branch 'LL-7937' of github.com:LedgerHQ/ledger-live-mobile into…

e776e9e

… LL-7937

Remove useless dependency to hw-app-btc (#1962)

2fa2305

* Remove useless dependency to hw-app-btc * Also remove hw-app-eth and hw-app-xrp

LL-7365 sunset stealthcoin (#1958)

63dfee3

New translations common.json (Russian) (#1964)

ecccf4a

Fix contrast of text colors in WebPlatformPlayer/InfoPanel (#1945)

df50ed7

update live-common

987f63f

remove header="modal" and update to new API

6d19297

(tab): update configs

057c124

(Tab): remove height from style

b2d36a8

remove tabBarVisible option

2073ed3

downgrade react-native-tab-view due to FlatList issue

e15228f

(AnimatedHeaderView): fix initial height issue

6d71733

Merge branch 'LL-7937' of github.com:LedgerHQ/ledger-live-mobile into…

fbfc397

… LL-7742

Merge branch 'develop' of github.com:LedgerHQ/ledger-live-mobile into…

cd1c672

… LL-7742

(Vitry): fix style provider theme merging issue

b9b31d1

remove unnecessary dep

10e8f6e

LL-8037 Use rebranded checkbox and switch components (#1978)

f3b7afd

* Use design system for Checkbox and Swich components * Removed useless @flow marker on checkbox file

Rebranding of the bottom modal and bump native ui library version (#1983

da0c231

)

LL-7745 - navigation footer rebrand (#1984)

f6ed99d

* Rebrand footer navigation * remove log

rebranding: Button proxy component (#1986)

99fafd8

LL-8036 - Infer font weight from LText to UI's Text, mark LTExt as de…

783ae7d

…precated (#1990)

(V3): update package.json

1d6d928

Upgrade @ledgerhq/native-ui to 0.3.0

24ba460

Upgrade pods

3d9df1a

LFBarreto and others added 22 commits March 20, 2022 23:44

(V3): nav reborn

f2670a3

LL-7742 ios Podfile updated

27ff5e9

(V3): bottom nav bar reverted design

a1a5364

Merge branch 'LL-7742' of github.com:LedgerHQ/ledger-live-mobile into…

8a65311

… LL-7742

add btn account if less than 3 accounts (#2316)

c829ee0

Merge branch 'develop' of github.com:LedgerHQ/ledger-live-mobile into…

0443493

… LL-7742

V3 - Add a scroll view to the new discover page (#2314)

65e50c5

Support/live 1667 cosmos tx flow cleanup (#2313)

11ed0fb

* LIVE-1667 Cosmos Select Amount to undelegate page updated * LL-1667 some cosmos transaction pages updated * LL-1667 SafeAreaView replaced with View in cosmos 01-Started.js

LL-1343 - Fix buy deeplink (#2318)

853cae9

Support/live 1669 polkadot tx flow cleanup (#2317)

115d2e9

* LL-1669 some polkadot transaction pages updated * LL-1669 ClearNominations and Nominate pages improved and fixed * LL-1669 console log removed

LL-1671- Rebrand firmware update notif in portfolio (#2319)

367091b

update llc

fb4c1fb

(V3): boost perfs (#2315)

35d6156

* (V3): boosty perfs * enable hermes for ios and polyfill intl * remove obsolete jsc flags * (Onboarding): fixes for small screens + some other issues Co-authored-by: Julien Elbaz <elbywan@hotmail.com>

LIVE-1779 - Settings QA Feedbacks (page title overflow, requireTerms …

aac693f

…overflow, resosurces bad urls) (#2323)

fix/LL 1665 some cleanup (#2327)

f9d15d9

* remove unused * update margin top

render errors to new flex and design system (#2326)

0c0988c

wrap and translation (#2325)

7783d85

fix uppercase (#2324)

1184212

Fix "regions" settings missing & feature regression in tsx files

984c367

using this diff as a reference https://github.com/LedgerHQ/ledger-live-mobile/pull/1941/files

Replace incorrect uses of useLocale by useSelector(localeSelector)

7c06d56

That's because useLocale returns the language locale and not the locale used for number & date formatting (they are separated)

Rename useLocale to useTranslationLocale to avoid confusion

332b163

Use proper locale in MarketStats

7720ae9

ofreyssinet-ledger self-assigned this Mar 24, 2022

ofreyssinet-ledger added 2 commits March 28, 2022 11:51

Try generating Intl imports (crashes at runtime)

f229265

Filter out "haw" locale (it crashes bc of an error in formatjs)

ada555c

ofreyssinet-ledger changed the title ~~Regions v3 regression~~ Regions v3 regression, Intl polyfill Mar 28, 2022

lint

3a6b90d

Base automatically changed from LL-7742 to release/v3.0.x March 29, 2022 12:28

ofreyssinet-ledger mentioned this pull request Apr 5, 2022

Regressions due to branching between JavaScript and TypeScript files #2389

Merged

Base automatically changed from release/v3.0.x to develop April 22, 2022 10:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Regions v3 regression, Intl polyfill #2332

Regions v3 regression, Intl polyfill #2332

ofreyssinet-ledger commented Mar 24, 2022 •

edited

Regions v3 regression, Intl polyfill #2332

Are you sure you want to change the base?

Regions v3 regression, Intl polyfill #2332

Conversation

ofreyssinet-ledger commented Mar 24, 2022 • edited

Type

Context

Parts of the app affected / Test plan

ofreyssinet-ledger commented Mar 24, 2022 •

edited