This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
LIVE-545 Add USB Firmware updates on Android #2432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-cortes
approved these changes
May 10, 2022
|
You need to update the dependencies @grsoares21 so that CI passes, I think rebasing develop and bumping everything over there should work. If we are relying on a custom live-common, perhaps you need to align things over there too, or if things are merged already, use the right version |
juan-cortes
suggested changes
May 10, 2022
|
You didn't manually fix yarn.lock right? This is the result of a yarn deduplicate or similar process? |
@juan-cortes it's the result of yarn-deduplicate |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the possibility of updating the firmware of the device via USB OTG on Android.
Not all firmware updates are supported. These are the devices than can be updated:
Nano S -> Version >= 1.6.1
Nano X -> Version >= 1.2.4-6
Nano S+ -> all
These refer to the current version of the device prior to the update.
screen-recording-20220428-163840-ll-dev-1_WYzfQ6tn.mp4
Type
Feature
Context
LIVE-545
Parts of the app affected / Test plan
Both the Portfolio page and the Manager page, present the firmware banner to the user if their device is out of date.
If the version is not supported, or the device is not connected via USB on Android, the user will be told to go to Desktop to update their device when clicking the update button. Otherwise the user will be directed to the update flow.
Updates to be tested:
LNS+:
LNS:
LNX:
If possible, to test with non supported versions to verify that the user is not able to access it.