Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 20 #1423

Closed
wants to merge 1 commit into from
Closed

Electron 20 #1423

wants to merge 1 commit into from

Conversation

gre
Copy link
Contributor

@gre gre commented Sep 29, 2022

πŸ“ Description

Another attempt to upgrade Electron 20.

to be continued

❓ Context

  • Impacted projects: ``
  • Linked resource(s): ``

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 29, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Oct 4, 2022 at 10:42AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 4, 2022 at 10:42AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 4, 2022 at 10:42AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 4, 2022 at 10:42AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022

⚠️ No Changeset found

Latest commit: 01ff85a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 70.77% // Head: 48.07% // Decreases project coverage by -22.69% ⚠️

Coverage data is based on head (01ff85a) compared to base (e7e36c8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1423       +/-   ##
============================================
- Coverage    70.77%   48.07%   -22.70%     
============================================
  Files           20      688      +668     
  Lines          681    30250    +29569     
  Branches       101     7908     +7807     
============================================
+ Hits           482    14544    +14062     
- Misses         174    14493    +14319     
- Partials        25     1213     +1188     
Flag Coverage Ξ”
test 48.07% <ΓΈ> (-22.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...mon/src/families/solana/api/chain/account/stake.ts 100.00% <0.00%> (ΓΈ)
libs/ledger-live-common/src/convert.ts 12.50% <0.00%> (ΓΈ)
...edger-live-common/src/families/celo/transaction.ts 47.05% <0.00%> (ΓΈ)
...bs/ledger-live-common/src/generated/transaction.ts 100.00% <0.00%> (ΓΈ)
...ommon/src/families/celo/js-estimateMaxSpendable.ts 54.54% <0.00%> (ΓΈ)
...ger-live-common/src/families/ethereum/bridge/js.ts 59.40% <0.00%> (ΓΈ)
.../ledger-live-common/src/families/polkadot/logic.ts 29.29% <0.00%> (ΓΈ)
...live-common/src/families/ethereum/hw-getAddress.ts 44.44% <0.00%> (ΓΈ)
libs/ledger-live-common/src/transaction/common.ts 55.10% <0.00%> (ΓΈ)
...common/src/families/osmosis/js-buildTransaction.ts 13.92% <0.00%> (ΓΈ)
... and 658 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Sep 29, 2022

@gre

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

macos

Actual Diff Expected
own-your-private-key-actual own-your-private-key-diff own-your-private-key-expected
own-your-private-key-actual own-your-private-key-diff own-your-private-key-expected
own-your-private-key-actual own-your-private-key-diff own-your-private-key-expected
own-your-private-key-actual own-your-private-key-diff own-your-private-key-expected

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

@gre

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

macos

Actual Diff Expected
own-your-private-key-actual own-your-private-key-diff own-your-private-key-expected
own-your-private-key-actual own-your-private-key-diff own-your-private-key-expected

@gre
Copy link
Contributor Author

gre commented Oct 4, 2022

#1463

@gre gre closed this Oct 4, 2022
@gre gre deleted the feat/electron-20 branch October 6, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant