feat(wallet-api): LLM & LLD server implementation [LIVE-4394] #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Justkant
requested review from
JunichiSugiura,
chabroA,
IAmMorrow,
RamyEB and
sprohaszka-ledger
🦋 Changeset detectedLatest commit: 54587ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
common
Justkant
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Screenshots: ❌
It seems this PR contains screenshots that are different from the base branch.
windows
|
Justkant
force-pushed
the
feat/wallet-api-LIVE-4394
branch
from
ce43898
to
98a32b7
Compare
3 tasks
Justkant
changed the title
Justkant
force-pushed
the
feat/wallet-api-LIVE-4394
branch
from
70a407a
to
25fd538
Compare
fix onResult for the action
already present in dummy-wallet-app
LLD is not setup for typescript, especially eslint
* add @types/uuid dev dep * hash the account id and create a uuidToAccountId map avoid sending account ids to a live app by creating a unique uuid from said account id and storing this uuid / account id pair in a map for easy retrival * add changeset * update existing test cases
Justkant
force-pushed
the
feat/wallet-api-LIVE-4394
branch
from
cb2566a
to
54587ae
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
We keep the old behaviour and codebase for v1 (live-app & live-app-sdk) and only use the Wallet API for v2 compatible manifests.
❓ Context
ledger-live-desktop,ledger-live-mobile,ledger-live-commonLIVE-4394✅ Checklist
📸 Demo
Manifest example for the new wallet-api debugger
{ "id": "debugger", "name": "Debugger", "url": "https://platform-app-debug-git-wallet-api-conversion-ledgerhq.vercel.app/", "homepageUrl": "https://platform-app-debug-git-wallet-api-conversion-ledgerhq.vercel.app/", "icon": "", "platform": "all", "apiVersion": "^2.0.0 || ~0.0.1", "manifestVersion": "1", "branch": "experimental", "categories": [], "currencies": ["*"], "content": { "shortDescription": { "en": "" }, "description": { "en": "" } }, "permissions": [ "account.list", "account.receive", "account.request", "currency.list", "device.close", "device.exchange", "device.transport", "message.sign", "transaction.sign", "transaction.signAndBroadcast", "wallet.capabilities" ], "domains": ["http://", "https://"] }🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.