Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force playwright @ 1.27.1 #1902

Merged
merged 1 commit into from Nov 21, 2022
Merged

force playwright @ 1.27.1 #1902

merged 1 commit into from Nov 21, 2022

Conversation

elbywan
Copy link
Contributor

@elbywan elbywan commented Nov 21, 2022

📝 Description

see: microsoft/playwright#18928

❓ Context

  • Impacted projects: ``
  • Linked resource(s): ``

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@elbywan elbywan requested a review from a team November 21, 2022 11:11
@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2022

⚠️ No Changeset found

Latest commit: 7f091b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Nov 21, 2022 at 11:11AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 21, 2022 at 11:11AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 21, 2022 at 11:11AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 21, 2022 at 11:11AM (UTC)

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 0.00% // Head: 42.51% // Increases project coverage by +42.51% 🎉

Coverage data is based on head (7f091b3) compared to base (2e5fd77).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1902       +/-   ##
============================================
+ Coverage         0   42.51%   +42.51%     
============================================
  Files            0      621      +621     
  Lines            0    25775    +25775     
  Branches         0     7116     +7116     
============================================
+ Hits             0    10958    +10958     
- Misses           0    14765    +14765     
- Partials         0       52       +52     
Flag Coverage Δ
test 42.51% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hain/instruction/associated-token-account/types.ts 100.00% <0.00%> (ø)
...e-common/src/currencies/BigNumberToLocaleString.ts 100.00% <0.00%> (ø)
...on/src/families/osmosis/js-getTransactionStatus.ts 100.00% <0.00%> (ø)
...n/src/families/polkadot/js-estimateMaxSpendable.ts 53.84% <0.00%> (ø)
...er-live-common/src/families/cardano/transaction.ts 32.00% <0.00%> (ø)
...ve-common/src/exchange/testCurrencyConfig/index.ts 85.71% <0.00%> (ø)
...live-common/src/families/ethereum/signOperation.ts 19.60% <0.00%> (ø)
.../src/families/solana/api/chain/validators/index.ts 100.00% <0.00%> (ø)
libs/ledger-live-common/src/hw/isDashboardName.ts 100.00% <0.00%> (ø)
...s/ledger-live-common/src/families/solana/errors.ts 100.00% <0.00%> (ø)
... and 611 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elbywan elbywan changed the title attempt to force playwright @ 1.27.1 force playwright @ 1.27.1 Nov 21, 2022
@github-actions
Copy link

@elbywan

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

macos

Actual Diff Expected
postonboarding-hub-inside-drawer-1-action-completed-actual postonboarding-hub-inside-drawer-1-action-completed-diff postonboarding-hub-inside-drawer-1-action-completed-expected
postonboarding-hub-inside-drawer-1-action-completed-actual postonboarding-hub-inside-drawer-1-action-completed-diff postonboarding-hub-inside-drawer-1-action-completed-expected

@elbywan elbywan merged commit dd7c82f into develop Nov 21, 2022
@elbywan elbywan deleted the support/fix-playwright branch November 21, 2022 12:25
cgrellard-ledger pushed a commit that referenced this pull request Nov 22, 2022
lambertkevin added a commit that referenced this pull request Nov 22, 2022
…ity (#1913)

* Prevents error on ERC1155 transfer without quantity

* Add fillTransactionData test for quantities [null]

* changeset

* Merge pull request #1902 from LedgerHQ/support/fix-playwright

force playwright @ 1.27.1

Co-authored-by: Julien Elbaz <elbywan@hotmail.com>
@valpinkman valpinkman mentioned this pull request Nov 22, 2022
3 tasks
lambertkevin added a commit that referenced this pull request Nov 22, 2022
…ity (#1913)

* Prevents error on ERC1155 transfer without quantity

* Add fillTransactionData test for quantities [null]

* changeset

* Merge pull request #1902 from LedgerHQ/support/fix-playwright

force playwright @ 1.27.1

Co-authored-by: Julien Elbaz <elbywan@hotmail.com>
valpinkman pushed a commit that referenced this pull request Nov 23, 2022
…ity (#1913)

* Prevents error on ERC1155 transfer without quantity

* Add fillTransactionData test for quantities [null]

* changeset

* Merge pull request #1902 from LedgerHQ/support/fix-playwright

force playwright @ 1.27.1

Co-authored-by: Julien Elbaz <elbywan@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD tools Has changes in tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants