Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLM - Lazy Load Screens #5471

Closed

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Nov 16, 2023

πŸ“ Description

In order for the app to open faster, we tried to lazy load some screens on LLM.
The same was done for LLD and it resulted in significant performance gains.

In order to measure the time for the app to start, we use the appTimeToInteractiveMilliseconds property from the StartupTimeMarker component which is accessible from the Settings > Debug > Performance.

After a first try where we lazy load about 35 screens in LLM, unfortunately we don't notice any improvement in the app start of LLM.

BEFORE

DEV :

1 - 22164 ms
2 - 21793 ms
3 - 21879 ms
4 - 22114 ms
5 - 22059 ms

Average : 22002 ms (22 seconds)

STAGING :

1 - 2960 ms
2 - 2917 ms
3 - 3122 ms
4 - 3031 ms
5 - 3228 ms
6 - 3230 ms
7 - 3457 ms
8 - 3262 ms
9 - 3130 ms
10 - 3141 ms

Average : 3148 ms (3,1 seconds)

❓ Context

βœ… Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • [ ] Impact of the changes:


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Nov 16, 2023 1:08pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 16, 2023 1:08pm
native-ui-storybook ⬜️ Ignored (Inspect) Nov 16, 2023 1:08pm
react-ui-storybook ⬜️ Ignored (Inspect) Nov 16, 2023 1:08pm
web-tools ⬜️ Ignored (Inspect) Nov 16, 2023 1:08pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Nov 16, 2023
Copy link

github-actions bot commented Dec 7, 2023

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label Dec 7, 2023
@github-actions github-actions bot closed this Dec 15, 2023
@KVNLS KVNLS deleted the support/LIVE-9814-llm-lazy-load-screens branch April 2, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant