Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf to at least 3.20 #40

Merged
merged 2 commits into from Jul 26, 2022
Merged

Update protobuf to at least 3.20 #40

merged 2 commits into from Jul 26, 2022

Conversation

niooss-ledger
Copy link
Contributor

Protobuf 3.20 is not backward-compatible, as explained in https://github.com/protocolbuffers/protobuf/releases/tag/v3.20.0 . As commit 01c6639 ("Generate pb2 code with recent protoc") updated the protobuf files, the dependency also needs to be bumped:

[Breaking change] Protobuf python generated codes are simplified. Descriptors and message
classes' definitions are now dynamic created in internal/builder.py.
Insertion Points for messages classes are discarded.

Protobuf 3.20 is not backward-compatible, as explained in
https://github.com/protocolbuffers/protobuf/releases/tag/v3.20.0 .
As commit 01c6639 ("Generate pb2 code with recent protoc") updated
the protobuf files, the dependency also needs to be bumped.
@danroc
Copy link
Contributor

danroc commented Jul 18, 2022

In this case, setup.py should probably be updated to drop support for Python 3.6: protocolbuffers/protobuf#9480

Protobuf 3.20 does not support Python < 3.7, as described in protocolbuffers/protobuf#9480
@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jibeee jibeee merged commit 690dccb into master Jul 26, 2022
@jibeee jibeee deleted the update-protobuf-3.20 branch July 26, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants