Trend #110
Open
Trend #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brauliodiez
reviewed
Jan 8, 2021
|
|
||
| const foundIndex = result.indexOf(Math.max(...result)); | ||
|
|
||
| return playersCollection[foundIndex].vote; |
There was a problem hiding this comment.
Some feedback, this is business code, let's extract it to the define-trend.business.ts
Instead of using map and filter, why not using redux and do this in one go
If you use reduce in the proper way you can create an struct like. {xs: 3, s: 4}
nasdan
reviewed
Jan 8, 2021
| @@ -180,6 +181,12 @@ const ShowVotingResultsComponent: React.FC<ShowVotingResultsProps> = props => { | |||
| <div className={classes.containerComponent}> | |||
| <TablePlayerComponent playersCollection={playerVotingStatus} /> | |||
| </div> | |||
| <div className={classes.containerComponent}> | |||
| <h2 className={classes.title}>Trend</h2> | |||
There was a problem hiding this comment.
Why don't move this title inside TablePlayerTrendComponent as TablePlayerComponent? Please check TablePlayerComponent that use Typography and headingLevel prop to change heading components by props
nasdan
reviewed
Jan 8, 2021
| </TableRow> | ||
| </TableHead> | ||
| <TableBody className={classes.body}> | ||
| <TableRow key={1}> |
There was a problem hiding this comment.
If we don't have a map, we don't need to use key prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added trend functionality. When votes are tailed, it shows the preferred option.