Swap linux-arm build to use linux-arm64-lts
#71
Conversation
|
Do you reckon this can be released as semver-patch? Is there any reason that downgrading glibc could be a breaking change? |
So far as I'm aware from my testing, compiling on a lower GLIBC is only more inclusive of targets, not less. The compilation would have failed if we had too old a GLIBC, so a patch should be fine |
|
Alright, and we won't need the |
We won't know until we run the Github release action - I needed it to do builds locally, but your Action has previously worked without that update, and my hope is it will do so again. If that fails, we'll need to submit that PR upstream to both |
|
Added 89397fd and running it on |
|
Failed with the openssl_fips error. I reckon it worked previously because the docker images were using an older node version. |
|
In any case it's unrelated to this PR so I'll go ahead and merge this. Could you send another PR to fix the |
Darn, seems like the same issue: https://github.com/Level/classic-level/actions/runs/4471788122/jobs/7857118969#step:5:48 I have no idea why this would have cropped up since the last build - these are the same dependency versions, and this failed on android-arm, which is unchanged, so I can only assume some environmental difference is now at play. Some more research reveals it may be the case that Node 14 previously included an So it seems like it should be possible to add that variable to the node |
|
@cswendrowski In case you missed it because we wrote our comments at the same time: #71 (comment) |
Ah neat, I hadn't noticed those weren't in the submodule. PR open! #72 |
Two problems to fix with this one - our rpi arm64 isn't working possibly because our libc is too new, so we'll target the lts of arm64, worked for [level](Level/classic-level#71) thankful for [their investigation](Level/classic-level#69) - our arm64 builds were just broken and wouldn't build so we're fixing that with a
Two problems to fix with this one - our rpi arm64 isn't working possibly because our libc is too new, so we'll target the lts of arm64, worked for [level](Level/classic-level#71) thankful for [their investigation](Level/classic-level#69) - our arm64 builds were just broken and wouldn't build so we're fixing that with a variable in our binding.gyp for `openssl_fips` When this is released it will hopefully fix serialport/node-serialport#2438
It took a lot of time to build and verify, but I was able to confirm this brings down the compiled GLIBC.
Closes #69.