Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferWrapper: partitions w/ sig slicing #1153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sk1p
Copy link
Member

@sk1p sk1p commented Nov 12, 2021

Supersedes #1025.

Support partitions that don't contain whole signal elements / frames, but slice the signal dimension.

TODO

  • Support in memory dataset
  • Tests for included UDFs with sig-slicing partitions
  • Maybe updates for other included UDFs?
  • Update UDF documentation

Contributor Checklist:

Reviewer Checklist:

  • /azp run libertem.libertem-data passed

Support partitions that don't contain whole signal elements / frames,
but slice the signal dimension.

Extracted from LiberTEM#1025
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #1153 (8a5ea2a) into master (ea22b51) will decrease coverage by 7.52%.
The diff coverage is 91.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1153      +/-   ##
==========================================
- Coverage   70.35%   62.83%   -7.53%     
==========================================
  Files         273      273              
  Lines       13281    13310      +29     
  Branches     1890     1893       +3     
==========================================
- Hits         9344     8363     -981     
- Misses       3581     4636    +1055     
+ Partials      356      311      -45     
Impacted Files Coverage Δ
src/libertem/common/math.py 84.61% <50.00%> (-15.39%) ⬇️
src/libertem/io/dataset/base/tiling.py 83.47% <71.42%> (-0.88%) ⬇️
src/libertem/executor/base.py 77.87% <83.33%> (-0.51%) ⬇️
src/libertem/common/buffers.py 84.36% <92.85%> (+0.31%) ⬆️
src/libertem/udf/base.py 93.99% <100.00%> (+0.01%) ⬆️
src/libertem/udf/masks.py 85.91% <100.00%> (+0.40%) ⬆️
src/libertem/udf/sumsigudf.py 76.92% <100.00%> (+4.19%) ⬆️
src/libertem/io/dataset/dm.py 32.11% <0.00%> (-55.48%) ⬇️
src/libertem/io/dataset/k2is.py 28.48% <0.00%> (-48.76%) ⬇️
src/libertem/io/dataset/mrc.py 43.69% <0.00%> (-46.22%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea22b51...8a5ea2a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant