-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merlin: try ScanX
and ScanY
from the HDR file
#1631
base: master
Are you sure you want to change the base?
Conversation
/azp run libertem.libertem-data |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run libertem.libertem-data |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1631 +/- ##
==========================================
- Coverage 70.02% 65.79% -4.23%
==========================================
Files 325 325
Lines 27255 27257 +2
Branches 3139 3140 +1
==========================================
- Hits 19084 17933 -1151
- Misses 7615 8817 +1202
+ Partials 556 507 -49 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Might be good to add a changelog entry to mention that this is now supported?
I will ask if there are any small data sets available with this metadata.
Thanks for having a look! Changelog entry added.
Thanks, that would be great 👍 If not, I'll add some unit tests instead that exercise the added logic. |
Test failure looks spurious, something to fix after the 0.14 release probably:
|
Fixes #1630
Contributor Checklist:
Reviewer Checklist:
/azp run libertem.libertem-data
passed