Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for loading data from zarr Arrays #997

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sk1p
Copy link
Member

@sk1p sk1p commented Mar 17, 2021

Work in progress, just to keep track of things in flight.

Can possibly benefit from sharing some code with HDF5 DataSet. In addition, we could add a tensorstore backend.

TODO

  • clean up: share more code with HDF5 DS, remove some copy-pasta
  • add tests
  • sync_offset and reshaping support, can possibly be added together with HDF5 (should be very similar!)
  • add to list of supported formats at libertem.io.dataset
  • possibly look into replacing our custom raw cache format with zarr arrays (per partition?) - probably via the nice tensorstore interface

Contributor Checklist:

Reviewer Checklist:

  • /azp run libertem.libertem-data passed

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #997 (0aa4dcb) into master (346d433) will decrease coverage by 34.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #997       +/-   ##
===========================================
- Coverage   68.87%   34.78%   -34.10%     
===========================================
  Files         260      261        +1     
  Lines       11977    12196      +219     
  Branches     1640     1667       +27     
===========================================
- Hits         8249     4242     -4007     
- Misses       3412     7748     +4336     
+ Partials      316      206      -110     
Impacted Files Coverage Δ
src/libertem/io/dataset/base/tiling.py 79.06% <0.00%> (-10.51%) ⬇️
src/libertem/io/dataset/zarr_dataset.py 0.00% <0.00%> (ø)
src/libertem/io/dataset/base/coordinates.py 21.05% <0.00%> (-78.95%) ⬇️
src/libertem/io/utils.py 24.00% <0.00%> (-76.00%) ⬇️
src/libertem/analysis/radialfourier.py 23.07% <0.00%> (-74.62%) ⬇️
src/libertem/io/writers/base.py 24.19% <0.00%> (-74.20%) ⬇️
src/libertem/contrib/daskadapter.py 27.27% <0.00%> (-72.73%) ⬇️
...ertem/web/notebook_generator/notebook_generator.py 27.27% <0.00%> (-72.73%) ⬇️
src/libertem/masks.py 15.46% <0.00%> (-72.38%) ⬇️
src/libertem/web/generator.py 28.57% <0.00%> (-71.43%) ⬇️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 346d433...0aa4dcb. Read the comment docs.

@uellue
Copy link
Member

uellue commented Feb 21, 2024

@sivborg and @magnunor are using Zarr for their 4D STEM work with HyperSpy/pyxem, so this could perhaps be moved up in priority? :-)

Refs #1277

@matbryan52
Copy link
Member

@sivborg and @magnunor are using Zarr for their 4D STEM work with HyperSpy/pyxem, so this could perhaps be moved up in priority? :-)

Refs #1277

If you like I could pick this up again?

@sk1p
Copy link
Member Author

sk1p commented Feb 21, 2024

If you like I could pick this up again?

Sure, go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants