Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin coverage<6.3 #11635

Merged
merged 10 commits into from
Jan 27, 2022
Merged

Pin coverage<6.3 #11635

merged 10 commits into from
Jan 27, 2022

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Jan 26, 2022

What does this PR do?

Fixes #11633.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

cc @tchaton @rohitgr7 @akihironitta @carmocca @Borda

@akihironitta akihironitta added bug Something isn't working ci Continuous Integration labels Jan 26, 2022
@akihironitta akihironitta changed the title Fix termination on macOS and Ubuntu in CI Pin coverage<6.3 Jan 26, 2022
@akihironitta
Copy link
Contributor Author

Here's the minimal reproducible command and its error msg

$ coverage --version
Coverage.py, version 6.3 with C extension
Full documentation is at https://coverage.readthedocs.io
$ coverage run -m pytest tests/trainer/connectors/test_signal_connector.py::test_signal_handlers_restored_in_teardown -vv
=============================================================== test session starts ===============================================================
platform linux -- Python 3.9.6, pytest-6.2.5, py-1.10.0, pluggy-1.0.0 -- /home/nitta/.pyenv/versions/miniconda3-latest/envs/dev-pl39/bin/python
cachedir: .pytest_cache
rootdir: /home/nitta/work/github.com/PyTorchLightning/pytorch-lightning, configfile: setup.cfg
plugins: rerunfailures-10.2, hydra-core-1.1.1
collected 1 item                                                                                                                                  

tests/trainer/connectors/test_signal_connector.py::test_signal_handlers_restored_in_teardown FAILED                                         [100%]

==================================================================== FAILURES =====================================================================
____________________________________________________ test_signal_handlers_restored_in_teardown ____________________________________________________

    @RunIf(skip_windows=True)
    @mock.patch.dict(os.environ, {"PL_FAULT_TOLERANT_TRAINING": "1"})
    def test_signal_handlers_restored_in_teardown():
        """Test that the SignalConnector restores the previously configured handler on teardown."""
>       assert signal.getsignal(signal.SIGTERM) is signal.SIG_DFL
E       assert <bound method Coverage._on_sigterm of <coverage.control.Coverage object at 0x7f75a9ee05b0>> is <Handlers.SIG_DFL: 0>
E        +  where <bound method Coverage._on_sigterm of <coverage.control.Coverage object at 0x7f75a9ee05b0>> = <function getsignal at 0x7f75a9d98820>(<Signals.SIGTERM: 15>)
E        +    where <function getsignal at 0x7f75a9d98820> = signal.getsignal
E        +    and   <Signals.SIGTERM: 15> = signal.SIGTERM
E        +  and   <Handlers.SIG_DFL: 0> = signal.SIG_DFL

tests/trainer/connectors/test_signal_connector.py:34: AssertionError
============================================================= short test summary info =============================================================
FAILED tests/trainer/connectors/test_signal_connector.py::test_signal_handlers_restored_in_teardown - assert <bound method Coverage._on_sigterm ...
========================================================== 1 failed, 4 warnings in 0.53s ==========================================================

@akihironitta akihironitta added this to the 1.5.x milestone Jan 26, 2022
@akihironitta akihironitta marked this pull request as ready for review January 26, 2022 19:20
@akihironitta akihironitta added the priority: 0 High priority task label Jan 26, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jan 27, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Contributor

@daniellepintz daniellepintz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue! Can we override the queued GPU test to merge this?

@akihironitta
Copy link
Contributor Author

Can we override the queued GPU test to merge this?

@daniellepintz I don't think that's feasible without the repo "admin" privilege since it's one of the jobs that are required to pass before merging. In my understanding, #11634 blocks all PRs basically...

@lexierule lexierule merged commit cfb0411 into master Jan 27, 2022
@lexierule lexierule deleted the ci/fix-term branch January 27, 2022 21:25
@carmocca carmocca mentioned this pull request Feb 8, 2022
12 tasks
carmocca pushed a commit that referenced this pull request Feb 8, 2022
rohitgr7 pushed a commit that referenced this pull request Feb 8, 2022
lexierule pushed a commit that referenced this pull request Feb 9, 2022
@akihironitta akihironitta mentioned this pull request May 23, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_signal_handlers_restored_in_teardown failing on mac and linux
7 participants