Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKG: distribute single semver #15374

Merged
merged 31 commits into from
Nov 12, 2022
Merged

PKG: distribute single semver #15374

merged 31 commits into from
Nov 12, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 27, 2022

What does this PR do?

unify all pkg versions
in case you run from source without install provide commit hash

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @akihironitta

@Borda Borda requested a review from carmocca October 28, 2022 22:45
@Borda
Copy link
Member Author

Borda commented Oct 31, 2022

ok, changed to have distributed the version.info so there is no overwrite of __version__.py 🦦
@carmocca @justusschock can you please check it again :)

@Borda Borda enabled auto-merge (squash) November 1, 2022 10:49
@mergify mergify bot removed the has conflicts label Nov 1, 2022
src/lightning/__version__.py Outdated Show resolved Hide resolved
src/lightning_app/__version__.py Outdated Show resolved Hide resolved
src/lightning_lite/__version__.py Outdated Show resolved Hide resolved
src/pytorch_lightning/__version__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any assertion in CI to avoid distributing packages with the wrong version info? something like:

python -c "assert pl.__version__ == '${{ ... }}'"

@mergify mergify bot added the ready PRs ready to be merged label Nov 1, 2022
src/lightning/__version__.py Outdated Show resolved Hide resolved
src/lightning_app/__version__.py Outdated Show resolved Hide resolved
src/lightning_lite/__version__.py Outdated Show resolved Hide resolved
src/pytorch_lightning/__version__.py Outdated Show resolved Hide resolved
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Nov 1, 2022
@Borda
Copy link
Member Author

Borda commented Nov 1, 2022

Is there any assertion in CI to avoid distributing packages with the wrong version info? something like:

python -c "assert pl.__version__ == '${{ ... }}'"

good idea, we can also add in another PR, the if pypi release workflow is in action we would check if the generated version is the same as input git tag...

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Nov 1, 2022
@mergify mergify bot added ready PRs ready to be merged and removed ready PRs ready to be merged labels Nov 10, 2022
@mergify mergify bot added has conflicts ready PRs ready to be merged and removed ready PRs ready to be merged has conflicts labels Nov 11, 2022
@carmocca carmocca marked this pull request as draft November 11, 2022 13:28
@carmocca carmocca marked this pull request as ready for review November 11, 2022 13:31
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Nov 11, 2022
@Borda Borda enabled auto-merge (squash) November 12, 2022 08:56
@carmocca carmocca removed the admin Requires admin privileges to merge label Nov 12, 2022
@Borda Borda merged commit 61ee3fa into master Nov 12, 2022
@Borda Borda deleted the pkg/version branch November 12, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

9 participants