Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for React Hydration Errors with Cypress #29

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Workaround for React Hydration Errors with Cypress #29

merged 2 commits into from
Apr 10, 2024

Conversation

martin-carmona
Copy link
Contributor

@martin-carmona martin-carmona commented Apr 10, 2024 •
edited

Description

This PR resolves two issues introduced by the following pull request: #18

  1. A workaround to handle React Hydration errors with Cypress
  2. Update the .gitignore file for Cypress related directories

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Verified that the Cypress GitHub Action succeeded

Checklist:

  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have reviewed the Security Best Practices Document.
  • I have followed the Naming Conventions Guide for my changes.
  • I have ensured that my pull request title is descriptive.

@vercel Vercel
Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
landing-page ❌ Failed (Inspect) Apr 10, 2024 1:40am

@martin-carmona martin-carmona changed the title Bugfix/fix hydration errors Workaround for React Hydration Errors with Cypress Apr 10, 2024
ChTiSh
ChTiSh approved these changes Apr 10, 2024
View reviewed changes
cypress/support/index.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Martin!

zhiyi15
zhiyi15 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@zhiyi15 zhiyi15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Martin!

@martin-carmona martin-carmona added this pull request to the merge queue Apr 10, 2024
Merged via the queue into dev with commit 17bb57a Apr 10, 2024
2 of 3 checks passed
@martin-carmona martin-carmona deleted the bugfix/fix-hydration-errors branch April 10, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChTiSh ChTiSh ChTiSh approved these changes

@zhiyi15 zhiyi15 zhiyi15 approved these changes

@dcpavel dcpavel Awaiting requested review from dcpavel

@kinskiwu kinskiwu Awaiting requested review from kinskiwu

@LucieSeidler LucieSeidler Awaiting requested review from LucieSeidler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martin-carmona @ChTiSh @zhiyi15