Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for Next.js Errors with Cypress #31

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Workaround for Next.js Errors with Cypress #31

merged 1 commit into from
Apr 12, 2024

Conversation

martin-carmona
Copy link
Contributor

@martin-carmona martin-carmona commented Apr 11, 2024 •
edited

Description

This PR adds a workaround for Cypress errors observed in the following draft pull requests:

It seems that Next.js 13.5.6 and above introduced this error.

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Verified that the Cypress GitHub Action succeeded

Checklist:

  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have reviewed the Security Best Practices Document.
  • I have followed the Naming Conventions Guide for my changes.
  • I have ensured that my pull request title is descriptive.

@vercel Vercel
Copy link

vercel bot commented Apr 11, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
landing-page ❌ Failed (Inspect) Apr 11, 2024 8:26pm

@martin-carmona martin-carmona changed the title add workaround for nextjs cypress error Workaround for Next.js Errors with Cypress Apr 11, 2024
dcpavel
dcpavel approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@dcpavel dcpavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with noting this is the recommended workaround: cypress-io/cypress#27204

@ChTiSh ChTiSh self-requested a review April 12, 2024 15:55
@ChTiSh ChTiSh added this pull request to the merge queue Apr 12, 2024
Merged via the queue into dev with commit 8130e10 Apr 12, 2024
2 of 3 checks passed
@martin-carmona martin-carmona deleted the bugfix/nextjs-cypress-error-workaround branch April 12, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcpavel dcpavel dcpavel approved these changes

@ChTiSh ChTiSh ChTiSh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martin-carmona @dcpavel @ChTiSh