Update Github trending widget #1562
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alhazmy13
changed the title
Lissy93
requested changes
May 16, 2024
There was a problem hiding this comment.
Thanks @alhazmy13 - looks good :)
Just a small thing, make sure the lint checks pass, e.g. single quotes
| @@ -77,11 +77,11 @@ export default { | |||
| slug: repo.repo, | |||
| desc: repo.desc, | |||
| lang: repo.lang, | |||
| link: repo.repo_link, | |||
| link: "https://github.com" + repo.repo, | |||
There was a problem hiding this comment.
Double quotes will fail the linter. Also, we can can use string interpolation.
- link: "https://github.com" + repo.repo,
+ link: `https://github.com/${repo.repo}`,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)
Category:
Update the widget URL
Overview
This pull request updates the URL for the GitHub trending widget. It changes from the forked repository (https://github.com/Lissy93/gh-trending-no-cors) to the original repository (https://github.com/doforce/github-trending). This update is necessary because the application deployed from the forked repository (https://gh-trending-repos.herokuapp.com/repo) is no longer available, with this change we do update the widget UI & Paramter to match the new response schema for the project.
Code Quality Checklist (Please complete)