Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable public application OIDC client support #1573

Merged
merged 1 commit into from May 13, 2024

Conversation

twsouthwick
Copy link
Contributor

@twsouthwick twsouthwick commented May 9, 2024

twsouthwick Medium twsouthwick /oidc → Lissy93/dashy Commits: 1 | Files Changed: 9 | Additions: 196 Label Powered by Pull Request Badge

Category:

Feature

Overview
This change uses oidc-client-ts to enable dashy to authenticate as an OIDC client. It populates the groups and roles so that it can be used the same as keycloak for showing/hiding elements on the dashboard.

Issue Number #823

New Vars

  • Added config options for appConfig:auth:oidc
  • Added oidc-client-ts as a dependency

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@twsouthwick twsouthwick requested a review from Lissy93 as a code owner May 9, 2024 06:12
Copy link

netlify bot commented May 9, 2024

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit b9902e3
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/663c6c30fc99aa0008f211a5
😎 Deploy Preview https://deploy-preview-1573--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This change uses oidc-client-ts to enable dashy to authenticate with as OIDC client. It populates the groups and roles so that it can be used the same as keycloak for showing/hiding elements on the dashboard.
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @twsouthwick
So sorry for the delay in reviewing this, it looks awesome!
Really well written! I'm just testing it out now, and will merge shortly :)

@Lissy93 Lissy93 merged commit 4b919f8 into Lissy93:master May 13, 2024
9 checks passed
@twsouthwick twsouthwick deleted the oidc branch May 13, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants