Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fixing text padding #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Fixing text padding #111

wants to merge 1 commit into from

Conversation

levjj
Copy link
Contributor

@levjj levjj commented Feb 22, 2013

The width of the text node does not compensate correctly for padding.

Example Code

var str = 'hmmmmmmmmmmm';
var txt = new lively.morphic.Text(lively.rect(20,10,60,50), str);
txt.openInWorld();
txt.focus();
txt.setPadding(lively.Rectangle.inset(5, 10));

Result

paddingbug

@rksm
Copy link
Member

rksm commented Mar 11, 2013

@levjj something is really wrong here: the pic below shows the padding that was set in red and the actual in blue. Could you please check and then open a new PR? Thanks!

padding-bug

@rksm rksm closed this Mar 11, 2013
@levjj
Copy link
Contributor Author

levjj commented Mar 12, 2013

I just checked with the current master and the text padding bug (as described above) is still present. The patch fixes this bug but breaks a few other things in the process, so it's still WIP (work in progress). We should not merge this yet but I would suggest to reopen the pull request or at least create a new issue for it.

@levjj levjj reopened this Mar 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants