Event cleanup #137
Open
Event cleanup #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uble check for command clicks
… move delta this fixes issues when move deltas are not captured to to missing events when there is heavy load or hand leaves the browser
|
Hmm this still needs to be done. I remember that the changes required to get rid of EventExperiments.js were more complicated than I expected. The tricky part is to translate the morphic locking behavior so that no layers are used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a larger code cleanup and gets rid of lively.EventExperiments.
With evt.getTargetMorph() we get a fast and central mechanism to lookup morphs that are event targets. This allows to put "meta event handling" (halos, "that", drag dispatch, etc.) in the mouse down/up/move handlers of the World which considerably frees the default mouse(down/up)entry methods of Morph.
Caveat, though: This mechanism uses the DOM (which makes it fast) and does not consider specific Morphic handling. E.g. when "grabbing" a morph and trying to find a drop target for it this mechanism can not be used because the grabbed morph will "block" other morphs. For this we still need #morphsContainingPoint.