New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code generation produces invalid JavaScript #251

Open

levjj wants to merge 2 commits into master from jscodegen-fix

Contributor

levjj commented Apr 7, 2014

The default code generation for an AST that calls a function node is in broken.

In the following example...

var src = "(function() { return 23; })()";
var src2 = lively.ast.Parser.parse(src, "topLevel").asJS();  //  "function() { return 23 }()";

...src2 omits the parantheses around the function literal which produces code that cannot be parsed. This effects both Chrome and Firefox.

The attached patch fixes this bug.

levjj added 2 commits

April 6, 2014 16:55


          added test for Call2JS bug

48fc489


          fixed Call2JS bug

e43ffbd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment