Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for zsh-fast-syntax-highlighting #909

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

motheki
Copy link

@motheki motheki commented Mar 21, 2024

Hello,

I would like to add support for zsh-fast-syntax-highlighting which has marginally better performance than zsh-syntax-highlighting, to the zsh configuration module in nix-darwin.

The repository can be found here

There is an existing nix package for zsh-fast-syntax-highlighting here

@Samasaur1
Copy link
Contributor

Would there be any problems if both zsh-syntax-highlighting and zsh-fast-syntax-highlighting are enabled at the same time?

@motheki
Copy link
Author

motheki commented Mar 24, 2024

@Samasaur1 Not from my testing. I have had both enabled at multiple points in time and zsh-fast-syntax-highlighting seems to take precedence.

@Samasaur1
Copy link
Contributor

I think there should still probably be a warning when both options are enabled, since zsh-syntax-highlighting won't take effect if both are enabled.

@motheki motheki force-pushed the fast-syntax-highlighting-support branch from 542aa95 to 44c8848 Compare May 29, 2024 17:25
@motheki
Copy link
Author

motheki commented May 29, 2024

@Samasaur1 Thank you for your patience. I took some time to add a warning that Zsh-Syntax-highlighting and zsh-fast-synatx-highlighting are mutually exclusive. Let me know if there is anything else that needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants