-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file or directory tile to Dock persistent others #950
Add file or directory tile to Dock persistent others #950
Conversation
0a1571a
to
9f5a59f
Compare
51186d6
to
9f56f18
Compare
@Samasaur1 or @Enzime PR #928 doesn't work, I'm trying to fix it.
Are you able to help? Thanks |
It's probably a similar error to last time. What I did to figure that out was to checkout the PR locally and run the tests, so that you have both of those files. Then I |
@Samasaur1 I am trying to run the PR locally, but it doesn't generate the file |
@rmgpinto What do you mean it "doesn't generate"? The logs give you the paths to two files in the Nix store — those are what I'm talking about |
You probably want to
Find the block that is almost exactly the same. It should be pretty clear what the problem is |
209978a
to
17e0f06
Compare
@Samasaur1 thanks, it worked now. |
6c74133
to
2b41918
Compare
@Enzime ready with your proposed changes. Thanks |
Can you rebase over the latest master? Everything else looks good to me 👍 |
a1055c2
to
93913d1
Compare
done @Enzime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the contribution
Added file or directory tile to Dock persistent others.
This will either expand directories or open files directly.