New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle null locales #63

Merged

paullla merged 2 commits into Locastic:master from guillaume-sainthillier:handle-null-locales

Jul 25, 2023

Contributor

guillaume-sainthillier commented Jul 20, 2023 •

edited

This PR allow the handling of null locale in translation without bug on doctrine/collection^2 by skipping the add.

For me, next major version should not allow null locale in the core.

Another solution could be to treat null locale as same as the default one.

guillaume-sainthillier added 2 commits

July 20, 2023 14:29


          add more php versions to unit tests

f2a7df0


          handle nullable locale

29834d6

paullla merged commit b8e612c into Locastic:master

4 checks passed

Member

paullla commented Jul 25, 2023

@guillaume-sainthillier thank you for the PR!

guillaume-sainthillier deleted the handle-null-locales branch

January 12, 2024 10:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment