Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump browser build dependencies to Node 20 #37

Merged
merged 1 commit into from Mar 14, 2024

Conversation

dnzxy
Copy link
Contributor

@dnzxy dnzxy commented Mar 11, 2024

Bumping dependencies for browser build, see LoopKit/LoopWorkspace#120 for detailed description.

@gestrich
Copy link
Collaborator

@dnzxy Did you get a chance to test that Caregiver browser builds are still successful after this version update?

@dnzxy
Copy link
Contributor Author

dnzxy commented Mar 13, 2024

@gestrich In all transparency, no, I have not; but this has been merged in iAPS already and is in use there, and there is not a single thing that comes to mind that would break the fastlane build using updated checkout, sync and artifact actions. It is only necessary to confer to newer requirements by GitHub for the used NodeJS version in actions.

Let me spin up a browser build on my end and quickly verify it for completeness sake.

@gestrich gestrich merged commit c2dbdef into LoopKit:dev Mar 14, 2024
@marionbarker
Copy link
Contributor

marionbarker commented Mar 14, 2024

I tested using the loopdocs-tester GitHub organization where I do most of my browser build testing.
I created a parallel PR to loopdocs-tester to branch update, which worked.

But I see you already merged.

Here is my successful build.

@gestrich
Copy link
Collaborator

@marionbarker Thanks for the verification!

@dnzxy dnzxy deleted the update-browserbuild-dependencies branch May 1, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants