Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gemfile.lock to bump Fastlane to 2.220.0 #126

Merged
merged 1 commit into from Apr 30, 2024
Merged

Conversation

dnzxy
Copy link

@dnzxy dnzxy commented Apr 28, 2024

This PR fixes apparent build issues that have been reported on Facebook and Zulip chat (cf. here).

This bug/issue leads to fastlane match failing when a user attempts to build and push multiple apps to the same Apple Developer account and Testflight. Quoting from Zulip chat:

Symptom - LoopWorkspace dev can only be built if it is the only repo that has been run after you nuke your certs and Match-Secrets. If you create certs for another repo later, then for LoopWorkspace: Validate Secrets (dev) fails. However, LoopWorkspace: Validate Secrets (main) succeeds and you can continue on to Build Loop (main).

After a lot of trial and error, updating fastlane from 2.215.0 to 2.220.0 seems to be an apparent fix to this issue. There have been many improvements around fastlane match throughout the last 5 minor releases (cf. here). Specifically fastlane #21578 and #21767 might be the fixes that solve our issue here.

In all transparency, I am not entirely sure, but updating fastlane has solved the issue – which was too reproducible and was reported by more than one person.

This PR should be merged in conjunction with #125 as both issues (this one, and the one solved with 125) break browser build and its automation features.

@marionbarker
Copy link
Contributor

This seems to only affect new dev builders or someone who has to renew their Distribution certificates. Several of us had scheduled builds succeed after this was first reported on Facebook on April 14.

To reproduce the problem:

  1. start with a username and repo that are all configured for Browser Build (known good secrets)
  2. delete your Match-Secrets repository
  3. delete your Apple Distribution certificates
  4. run Create Certificates using unmodified dev branch - it succeeds
  • Note: there is now one Distribution certificate on Apple page
  1. run Create Certificate with another repo (I have used LoopCaregiver and LoopFollow with same results)
  2. run Validate Secrets for dev branch - fails (which means all other actions will fail)
  • Note: at this point Validate Secrets and all other actions still succeed for main branch of LoopWorkspace
  1. run Validate Secrets using this fix-build modification - it succeeds and can continue to building
  • Continue to test all actions for fix-build succeed as expected:
    • Add Identifiers
    • Create Certificates
    • Build Loop

Note that there is still only one Distribution Certificate on the Apple page. (This is expected and the desired result.)

Final test: run 3 in a row Validate Secrets for LoopWorkspace:

  1. main branch succeeds
  2. dev branch fails
  3. fix-build branch succeeds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants