Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folia support #3615

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Folia support #3615

wants to merge 1 commit into from

Conversation

lucko
Copy link
Member

@lucko lucko commented Apr 1, 2023

Adds support for Paper's regionised/multithreading Folia project.

As you can see, there were fairly minimal changes required to get LuckPerms working, so I don't expect many bugs/issues. It has been lightly tested by me. :)

Test build

There is a jar you can download from Jenkins: https://ci.lucko.me/job/LuckPerms-Folia/

@lucko

This comment was marked as outdated.

@lucko lucko linked an issue Apr 1, 2023 that may be closed by this pull request
@pontaoski
Copy link

Needs rebase, but this seems to work for me on 1.19 Folia

@lucko

This comment was marked as outdated.

@pontaoski
Copy link

pontaoski commented Jun 25, 2023

bukkit/src/main/java/me/lucko/luckperms/bukkit/messaging/PluginMessageMessenger.java:63 should be updated to Folia; the Folia code would look something like

server.getAsyncScheduler().runAtFixedRate(plugin, task -> {
    Collection<? extends Player> players = PluginMessageMessenger.this.plugin.getBootstrap().getServer().getOnlinePlayers();
    Player p = Iterables.getFirst(players, null);
    if (p == null) {
        return;
    }

    p.sendPluginMessage(PluginMessageMessenger.this.plugin.getLoader(), CHANNEL, buf);
    task.cancel();
}, 20L, 2000L, TimeUnit.MILLISECONDS);


private static boolean isFolia() {
try {
Class.forName("io.papermc.paper.threadedregions.scheduler.RegionScheduler");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Class.forName("io.papermc.paper.threadedregions.scheduler.RegionScheduler");
Class.forName("io.papermc.paper.threadedregions.RegionizedServer");

paper api now includes the folia scheduler stuff

@ghost ghost mentioned this pull request Jun 28, 2023
@ranminecraft
Copy link

merge plz !

@ewof
Copy link

ewof commented Sep 13, 2023

foliabros..

@ewof
Copy link

ewof commented Sep 19, 2023

.

@powercasgamer
Copy link
Contributor

.

don't post useless comments on prs

@DxsSucuk
Copy link

DxsSucuk commented Nov 6, 2023

Anything new about this?

@lucko lucko added the type: new platform The issue is suggesting the implementation of a new platform / platform version. label Nov 6, 2023
@securebread
Copy link

is there a download for 1.20.2?

@SquareCodeFX
Copy link

@lucko how are things going here?

@lucko
Copy link
Member Author

lucko commented Jan 6, 2024

I have rebased this PR and updated to Folia 1.20.2 - builds are available from Jenkins: https://ci.lucko.me/job/LuckPerms-Folia/

@BearLeonLight
Copy link

What's the progress and when will it be merged?
Currently I'm using it normally on 1.20.4.

@iLemon
Copy link

iLemon commented May 23, 2024

pls merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: new platform The issue is suggesting the implementation of a new platform / platform version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Will LuckPerm work with Folia?
10 participants