Webpack 5 beta 22 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was merged into the master branch. Discussion ---------- Fixing babel.config.js filename in message Introduced in symfony#738 - @jdreesen I think this was just a typo? Can you confirm that my PR is right? Thanks! Commits ------- c163909 fixing babel.config.js filename in message
…ryan) This PR was merged into the master branch. Discussion ---------- Removing vue2 alias to use the full build Fixes symfony#674 Commits ------- bece20e removing vue2 alias to use the full build
This makes it harder for beginners and it's hard to know the fix. As a compromise, this alerts that there is an option to choose a smaller build.
Co-authored-by: Vincent Le Biannic <850046+Lyrkan@users.noreply.github.com>
…weaverryan)
This PR was squashed before being merged into the master branch.
Discussion
----------
Reverting change to only package vue runtime loader
Using the runtime build by default makes it harder for beginners and it's hard to know the fix. Specifically, if you follow the "intro docs" to Vue, you will likely try this:
```js
var app = new Vue({
el: '#app',
data: {
message: 'Hello Vue!'
}
})
```
which will not work (and the error will be tough for beginners to spot). As a compromise, on a production build, we print a recommendation so that people can discover the option to use the smaller build.
Commits
-------
6ae0aaa Update index.js
47f5ca3 Updating missing-loader for changing vue internal file syntax
1b393eb reverting change to only package vue runtime loader
There is currently a bug where, on a "watch" rebuild, sometimes an image that's referenced from a CSS file won't be "noticed" and will be mistakenly deleted.
… false (weaverryan) This PR was merged into the master branch. Discussion ---------- Setting CleanWebpackPlugin's cleanStaleWebpackAssets: false There is currently a bug where, on a "watch" rebuild, sometimes an image that's referenced from a CSS file won't be "noticed" and will be mistakenly deleted. Reproducer: https://github.com/weaverryan/clean_webpack_assets_watch_bug I haven't had time yet to "distill" that reproducer down to a raw `webpack.config.js` file (without Encore) so that I can submit an issue. But, since this behavior can be quite damaging (I was pulling out my hair trying to figure out why an image file was there sometimes and gone other times) and because the `cleanStaleWebpackAssets` is so *minor* (it removes extra files on `watch` rebuilds), I think we should just disable it by default. Commits ------- 39e4619 Setting CleanWebpackPlugin's cleanStaleWebpackAssets: false
# Conflicts: # lib/WebpackConfig.js # lib/friendly-errors/transformers/missing-loader.js
|
This update webpack to beta 22 for symfony#645 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.