-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change more classes to records #2313
Merged
KlemenDEV
merged 6 commits into
MCreator:master
from
Defeatomizer:java15-migration-warnings
Jan 30, 2022
Merged
Change more classes to records #2313
KlemenDEV
merged 6 commits into
MCreator:master
from
Defeatomizer:java15-migration-warnings
Jan 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KlemenDEV
requested changes
Jan 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes following code cleanup suggestions makes things less clear / introduces bugs. Each cleanup should be weighted if it is worth it
KlemenDEV
requested changes
Jan 27, 2022
src/main/java/net/mcreator/ui/vcs/MCreatorWorkspaceSyncHandler.java
Outdated
Show resolved
Hide resolved
KlemenDEV
approved these changes
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes more classes to the new record feature of J16.
This PR changes the following classes:
The following classes pretended to become records too:
generator
parameter to become visible by plugins, the only way to prevent that is to use the following code:VTextField
toJTextField
, like it's done in all the other validators;