Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications for Comments #2072

Open
gmeben opened this issue Mar 8, 2024 · 4 comments
Open

Notifications for Comments #2072

gmeben opened this issue Mar 8, 2024 · 4 comments
Labels
🕸️ backend Related to the Backend PHP API 💍 feature New feature or request 🖥️ frontend Related to the Vue/JS portions

Comments

@gmeben
Copy link
Contributor

gmeben commented Mar 8, 2024

Users are not notified when users add comments on submissions. This means users may not be aware of discussion activity on submissions they are reviewing.

Add notifications for comments added to a submission based on role and proximity to newly added comments.

Recipients

Newly Added Inline Comments

  • Submitters
  • Review Coordinators

Newly Added Inline Comment Replies

  • Submitters
  • Reviewers with an inline comment reply of the parent inline comment
  • Review Coordinators

Newly Added Overall Comment Replies

  • Submitters
  • Reviewers with an overall comment reply of the parent overall comment
  • Review Coordinators

Review Checklist

  • Submitters are notified of comments
  • Reviewers are notified of comments
  • Review Coordinators are notified of comments
  • Necessary backend unit testing has been added

Accessibility Checklist

  • No new color contrast issues are introduced
  • Changed text has a font size of at least 16px
  • Added text uses plain language
@gmeben gmeben added 🧹 needs-refinement Issues that need more detail in order to be ready for work to commence 🖥️ frontend Related to the Vue/JS portions 🕸️ backend Related to the Backend PHP API 💍 feature New feature or request ❓ question Further information is requested and removed 🧹 needs-refinement Issues that need more detail in order to be ready for work to commence labels Mar 8, 2024
@gmeben
Copy link
Contributor Author

gmeben commented Mar 8, 2024

The questions for this issue are:

  1. Do we agree on the specified recipients of these notifications?
  2. Do we agree on the criteria of these notifications: any comment added to a submission regardless of thread proximity?

(Update) Answers:

  1. No
  2. No

The recipients and criteria needed to be more selective. The description has been updated to reflect this.

@gmeben
Copy link
Contributor Author

gmeben commented Mar 8, 2024

@gmeben gmeben added 🧹 needs-refinement Issues that need more detail in order to be ready for work to commence and removed ❓ question Further information is requested labels Mar 25, 2024
@gmeben gmeben removed the 🧹 needs-refinement Issues that need more detail in order to be ready for work to commence label Apr 3, 2024
@sattler9
Copy link
Contributor

sattler9 commented Apr 3, 2024

Hey team! Please add your planning poker estimate with Zenhub @gmeben @vilagshe @wreality

@gmeben
Copy link
Contributor Author

gmeben commented Apr 3, 2024

I forgot to document from our team discussion on this prior to today that there was a desire to make these notifications in-app only, not email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕸️ backend Related to the Backend PHP API 💍 feature New feature or request 🖥️ frontend Related to the Vue/JS portions
Projects
None yet
Development

No branches or pull requests

2 participants