Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chg: [logging] Add user id to sys logged actions #8975

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from

Conversation

dragsu
Copy link

@dragsu dragsu commented Mar 22, 2023

When a user performs an action, the user id is not logged with it. As a result, when multiple users are doing changes in MIPS it is hard to track which user did what.

This change will prepend the user id to sys logged actions.

What does it do?

If it fixes an existing issue, please use github syntax: #8974

Questions

  • Does it require a DB change?
  • Are you using it in production?
  • Does it require a change in the API (PyMISP for example)?

When a user performs an action, the user id is not logged with it.
As a result, when multiple users are doing changes in MIPS it is hard to
track which user did what.

This change will prepend the user id to sys logged actions.
@adulau
Copy link
Member

adulau commented Mar 22, 2023

Thanks for the PR. It's a good idea. I'm just worried about the change of format as maybe some tools rely on it. @iglocska @mokaddem @righel what do think of it?

@dragsu
Copy link
Author

dragsu commented Mar 22, 2023

Pipeline failing due to PyMISP version mismatch.

self.assertEqual(self.user_misp_connector.version, self.user_misp_connector.pymisp_version_master) AssertionError: {'version': '2.4.169'} != {'version': '2.4.169.2'}

@dragsu
Copy link
Author

dragsu commented May 23, 2023

@adulau Can we please revisit this?

@JakubOnderka
Copy link
Contributor

I would recommend new ECS logging – it generates logs in structured JSON Elastic Common Schema format, which contains much more information and also user ID and user e-mail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants