Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update preprocessData with new user timing marks #43

Closed
taneliang opened this issue Jul 3, 2020 · 0 comments · Fixed by #63
Closed

Update preprocessData with new user timing marks #43

taneliang opened this issue Jul 3, 2020 · 0 comments · Fixed by #63
Assignees
@kartikcho
Labels
importance: 1 - must have Must be implemented for the issue's phase to be complete phase: 1 - MVP Tasks that get us to our initial MVP urgency: 1 - within 2 days work type: implementation A task that primarily involves bashing code
Projects
React Concurrent Mode Profiler

Comments

@taneliang
Copy link
Member

taneliang commented Jul 3, 2020 •
edited

Many User Timing marks have been updated in facebook/react#19223, breaking our profiler.

We could either wait until that PR is merged or start on this immediately if we're confident that the PR won't be changed significantly.

Acceptance Criteria

  • A profile generated using the final marks should be ingested without errors
  • The profile should appear in the canvas without errors
  • I think we can retain our --render-cancel mark handling code since we'll attempt to add it back to React (see: Attempt to re-add render abandoned/cancelled marks react#30)
  • No Flow errors in affected code
  • Updated tests
@taneliang taneliang created this issue from a note in React Concurrent Mode Profiler (To do) Jul 3, 2020
@taneliang taneliang mentioned this issue Jul 3, 2020
Merged
@taneliang taneliang added phase: 1 - MVP Tasks that get us to our initial MVP urgency: 1 - within 2 days work type: implementation A task that primarily involves bashing code importance: 1 - must have Must be implemented for the issue's phase to be complete labels Jul 8, 2020
@kartikcho kartikcho moved this from To do to In progress in React Concurrent Mode Profiler Jul 9, 2020
@kartikcho kartikcho mentioned this issue Jul 10, 2020
Merged
@kartikcho kartikcho moved this from In progress to Review in progress in React Concurrent Mode Profiler Jul 13, 2020
React Concurrent Mode Profiler automation moved this from Review in progress to Done Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kartikcho kartikcho

Labels
importance: 1 - must have Must be implemented for the issue's phase to be complete phase: 1 - MVP Tasks that get us to our initial MVP urgency: 1 - within 2 days work type: implementation A task that primarily involves bashing code
Projects
No open projects
React Concurrent Mode Profiler
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update preprocessData, add latest performance profile MLH-Fellowship/scheduling-profiler-prototype
2 participants
@taneliang @kartikcho