Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update preprocessData, add latest performance profile #63

Merged
merged 7 commits into from
Jul 13, 2020
Merged

Update preprocessData, add latest performance profile #63

merged 7 commits into from
Jul 13, 2020

Conversation

kartikcho
Copy link
Member

@kartikcho kartikcho commented Jul 10, 2020 •
edited

Resolves #43
Updated preprocessData.js to reflect the changes made in the React PR.
Also, removed 2 old perf profiles, create a new profile from updated changes.

Renamed profiles to "versions" of the scheduler-profiler where,

  • v0 => The original POC
  • v1 => Profiler before the React PR update
  • v2 => Latest upto date changes

This PR covers,

  • The profile appears in the canvas without errors
    (Warnings related to negative time deltas persist but they're not related to this)
  • No Flow errors in affected code
  • Updated tests

Don't merge before #64

@kartikcho kartikcho requested a review from taneliang July 10, 2020 08:43
taneliang
taneliang reviewed Jul 10, 2020
View reviewed changes
Copy link
Member

@taneliang taneliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR isn't complete as some of the other marks were changed as well

@kartikcho kartikcho requested a review from taneliang July 13, 2020 06:19
taneliang
taneliang approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@taneliang taneliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests were not updated and were still using the old format, apart from --schedule-render-.... In the interest of time, I've updated them.

@taneliang taneliang merged commit 70c25ad into master Jul 13, 2020
@taneliang taneliang deleted the update-preprocessing branch July 13, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taneliang taneliang taneliang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update preprocessData with new user timing marks
2 participants
@kartikcho @taneliang