Skip to content

Commit

Permalink
refactor: consistent type imports
Browse files Browse the repository at this point in the history
  • Loading branch information
lukashroch committed Jun 15, 2022
1 parent 608349d commit 65466e9
Show file tree
Hide file tree
Showing 352 changed files with 925 additions and 590 deletions.
4 changes: 4 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ module.exports = defineConfig({
'no-restricted-syntax': ['error', 'LabeledStatement', 'WithStatement'],
'no-shadow': 'off',
'@typescript-eslint/ban-types': 'warn',
'@typescript-eslint/consistent-type-imports': [
'error',
{ prefer: 'type-imports', disallowTypeAnnotations: false },
],
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/no-shadow': 'error',
'@typescript-eslint/no-unused-vars': ['warn', { ignoreRestSiblings: true }],
Expand Down
3 changes: 2 additions & 1 deletion apps/admin/src/app.vue
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@
<script lang="ts">
import groupBy from 'lodash/groupBy';
import pluralize from 'pluralize';
import Vue, { VueConstructor } from 'vue';
import type { VueConstructor } from 'vue';
import Vue from 'vue';
import type { Location } from 'vue-router';
import type { Dictionary } from '@intake24/common/types';
import { ConfirmDialog, setsLanguage, ServiceWorker } from '@intake24/ui';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
</template>

<script lang="ts">
import Vue, { VueConstructor, PropType } from 'vue';
import type { VueConstructor, PropType } from 'vue';
import Vue from 'vue';
import upperFirst from 'lodash/upperFirst';
import Delete from './delete.vue';
import Read from './read.vue';
Expand Down
3 changes: 2 additions & 1 deletion apps/admin/src/components/data-tables/data-table.vue
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@
</template>

<script lang="ts">
import Vue, { VueConstructor, PropType } from 'vue';
import type { VueConstructor, PropType } from 'vue';
import Vue from 'vue';
import { mapActions, mapState } from 'pinia';
import type { DataOptions } from 'vuetify';
import isEqual from 'lodash/isEqual';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@
</template>

<script lang="ts">
import Vue, { VueConstructor } from 'vue';
import type { VueConstructor } from 'vue';
import Vue from 'vue';
import type { DataOptions } from 'vuetify';
import isEqual from 'lodash/isEqual';
import type { Dictionary } from '@intake24/common/types';
Expand Down
3 changes: 2 additions & 1 deletion apps/admin/src/components/entry/detail-mixin.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import Vue, { VueConstructor } from 'vue';
import type { VueConstructor } from 'vue';
import Vue from 'vue';
import type { DetailMixin } from '@intake24/admin/types';
import fetchEntry from './fetch-entry';
import hasEntry from './has-entry';
Expand Down
3 changes: 2 additions & 1 deletion apps/admin/src/components/entry/fetch-entry.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import Vue, { VueConstructor } from 'vue';
import type { VueConstructor } from 'vue';
import Vue from 'vue';
import { mapActions } from 'pinia';
import type { HasEntryMixin } from '@intake24/admin/types';
import { useEntry } from '@intake24/admin/stores';
Expand Down
3 changes: 2 additions & 1 deletion apps/admin/src/components/entry/form-mixin.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import Vue, { VueConstructor } from 'vue';
import type { VueConstructor } from 'vue';
import Vue from 'vue';
import isEqual from 'lodash/isEqual';
import pick from 'lodash/pick';
import { mapActions } from 'pinia';
Expand Down
3 changes: 2 additions & 1 deletion apps/admin/src/components/entry/layout.vue
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@
</template>

<script lang="ts">
import Vue, { VueConstructor, PropType } from 'vue';
import type { VueConstructor, PropType } from 'vue';
import Vue from 'vue';
import has from 'lodash/has';
import { ConfirmDialog } from '@intake24/ui';
import hasResource from '@intake24/admin/mixins/has-resource';
Expand Down
3 changes: 2 additions & 1 deletion apps/admin/src/components/feedback/cards/card-list.vue
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@
</template>

<script lang="ts">
import { defineComponent, PropType, ref } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent, ref } from '@vue/composition-api';
import isEqual from 'lodash/isEqual';
import draggable from 'vuedraggable';
import type { Card } from '@intake24/common/feedback';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,12 @@

<script lang="ts">
import { useEntry } from '@intake24/admin/stores';
import { Character, characterTypes } from '@intake24/common/feedback';
import type { Character } from '@intake24/common/feedback';
import { characterTypes } from '@intake24/common/feedback';
import type { NutrientTypeEntry } from '@intake24/common/types/http/admin';
import { characterImageMap } from '@intake24/ui/feedback';
import { defineComponent, PropType } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import CharacterSentiments from '../partials/character-sentiments.vue';
export default defineComponent({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
</template>

<script lang="ts">
import { defineComponent, PropType } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import type { FiveADay } from '@intake24/common/feedback';
import CardContent from '../partials/card-content.vue';
import CardThresholds from '../partials/card-thresholds.vue';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@
</template>

<script lang="ts">
import { defineComponent, PropType } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import type { NutrientGroup } from '@intake24/common/feedback';
import type { NutrientTypeEntry } from '@intake24/common/types/http/admin';
import { useEntry } from '@intake24/admin/stores';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
</template>

<script lang="ts">
import { defineComponent, PropType } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import { tinymce } from '@intake24/admin/components/tinymce';
import { LanguageSelector } from '@intake24/admin/components/forms';
import type { RuleCallback } from '@intake24/admin/types';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@

<script lang="ts">
import isEqual from 'lodash/isEqual';
import { defineComponent, PropType } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import { tinymce } from '@intake24/admin/components/tinymce';
import { LanguageSelector } from '@intake24/admin/components/forms';
import type { CustomCard } from '@intake24/common/feedback';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@

<script lang="ts">
import isEqual from 'lodash/isEqual';
import { defineComponent, PropType } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import { tinymce } from '@intake24/admin/components/tinymce';
import { LanguageSelector } from '@intake24/admin/components/forms';
import type { RuleCallback } from '@intake24/admin/types';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,10 @@

<script lang="ts">
import isEqual from 'lodash/isEqual';
import { defineComponent, PropType } from '@vue/composition-api';
import {
Character,
characterSentimentTypes,
CharacterSentiment,
sentiments,
} from '@intake24/common/feedback';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import type { Character, CharacterSentiment } from '@intake24/common/feedback';
import { characterSentimentTypes, sentiments } from '@intake24/common/feedback';
import { LanguageSelector } from '@intake24/admin/components/forms';
import { copy } from '@intake24/common/util';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,10 @@

<script lang="ts">
import draggable from 'vuedraggable';
import { defineComponent, PropType, ref } from '@vue/composition-api';
import { DemographicGroup, nutrientRuleTypes, sexes } from '@intake24/common/feedback';
import type { PropType } from '@vue/composition-api';
import { defineComponent, ref } from '@vue/composition-api';
import type { DemographicGroup } from '@intake24/common/feedback';
import { nutrientRuleTypes, sexes } from '@intake24/common/feedback';
import type { NutrientTypeEntry } from '@intake24/common/types/http/admin';
import type { PhysicalActivityLevelAttributes } from '@intake24/common/types/models';
import { useEntry } from '@intake24/admin/stores';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
</template>

<script lang="ts">
import { defineComponent, PropType } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import type { Range } from '@intake24/common/feedback';
export type RangeType = 'age' | 'height' | 'weight';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,10 @@

<script lang="ts">
import isEqual from 'lodash/isEqual';
import { defineComponent, PropType } from '@vue/composition-api';
import { DemographicGroupScaleSector, sentiments } from '@intake24/common/feedback';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import type { DemographicGroupScaleSector } from '@intake24/common/feedback';
import { sentiments } from '@intake24/common/feedback';
import { tinymce } from '@intake24/admin/components/tinymce';
import { LanguageSelector } from '@intake24/admin/components/forms';
import { copy } from '@intake24/common/util';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,10 @@

<script lang="ts">
import draggable from 'vuedraggable';
import { defineComponent, PropType } from '@vue/composition-api';
import { HenryCoefficient, Sex, sexes } from '@intake24/common/feedback';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import type { HenryCoefficient, Sex } from '@intake24/common/feedback';
import { sexes } from '@intake24/common/feedback';
import { LoadSectionDialog } from '@intake24/admin/components/schemes';
import { ConfirmDialog } from '@intake24/ui';
import { getHenryCoefficientDefaults } from './henry-coefficient';
Expand Down
3 changes: 2 additions & 1 deletion apps/admin/src/components/feedback/list.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import isEqual from 'lodash/isEqual';
import { ref, SetupContext, toRefs, UnwrapRef, UnwrapRefSimple, watch } from '@vue/composition-api';
import type { SetupContext, UnwrapRef, UnwrapRefSimple } from '@vue/composition-api';
import { ref, toRefs, watch } from '@vue/composition-api';
import { copy } from '@intake24/common/util';

export type ListProps<T> = {
Expand Down
6 changes: 4 additions & 2 deletions apps/admin/src/components/feedback/preview/preview.vue
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@
</template>

<script lang="ts">
import { defineComponent, PropType } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import { FeedbackChartArea, FeedbackCardArea } from '@intake24/ui/components/feedback';
import { FeedbackCardParameters, buildTopFoods, buildCardParams } from '@intake24/ui/feedback';
import type { FeedbackCardParameters } from '@intake24/ui/feedback';
import { buildTopFoods, buildCardParams } from '@intake24/ui/feedback';
import type { FeedbackSchemeEntry } from '@intake24/common/types/http/admin';
import { feedbackService } from '@intake24/admin/services';
import * as previewData from './preview-data';
Expand Down
3 changes: 2 additions & 1 deletion apps/admin/src/components/feedback/top-foods/color-list.vue
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@

<script lang="ts">
import draggable from 'vuedraggable';
import { defineComponent, PropType } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import { useList } from '..';
export default defineComponent({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,11 @@
import draggable from 'vuedraggable';
import { ConfirmDialog } from '@intake24/ui';
import { LanguageSelector } from '@intake24/admin/components/forms';
import { defaultTopFoods, TopFoodNutrientType } from '@intake24/common/feedback';
import type { TopFoodNutrientType } from '@intake24/common/feedback';
import { defaultTopFoods } from '@intake24/common/feedback';
import type { NutrientTypeEntry } from '@intake24/common/types/http/admin';
import { defineComponent, PropType } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import type { RuleCallback } from '@intake24/admin/types';
import { useList } from '..';
Expand Down
3 changes: 2 additions & 1 deletion apps/admin/src/components/forms/auto-complete.vue
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
</template>

<script lang="ts">
import Vue, { VueConstructor, PropType } from 'vue';
import type { VueConstructor, PropType } from 'vue';
import Vue from 'vue';
import debounce from 'lodash/debounce';
import type { Dictionary } from '@intake24/common/types';
Expand Down
3 changes: 2 additions & 1 deletion apps/admin/src/components/forms/language-selector.vue
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@

<script lang="ts">
import type { LanguageListEntry } from '@intake24/common/types/http/admin';
import { defineComponent, PropType } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import type { LocaleTranslation } from '@intake24/common/types';
import { useEntry } from '@intake24/admin/stores';
Expand Down
3 changes: 2 additions & 1 deletion apps/admin/src/components/gallery/gallery.vue
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@
</template>

<script lang="ts">
import Vue, { VueConstructor, PropType } from 'vue';
import type { VueConstructor, PropType } from 'vue';
import Vue from 'vue';
import { mapActions, mapState } from 'pinia';
import type { Dictionary } from '@intake24/common/types';
import type { Pagination, PaginationMeta } from '@intake24/common/types/models';
Expand Down
3 changes: 2 additions & 1 deletion apps/admin/src/components/meals/meal-list.vue
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,8 @@
</template>

<script lang="ts">
import { defineComponent, PropType, ref } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent, ref } from '@vue/composition-api';
import draggable from 'vuedraggable';
import { copy } from '@intake24/common/util';
import type { Meal, Meals } from '@intake24/common/types';
Expand Down
3 changes: 2 additions & 1 deletion apps/admin/src/components/polls-for-jobs/polls-job-list.vue
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@
</template>

<script lang="ts">
import { defineComponent, PropType } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import type { JobEntry } from '@intake24/common/types/http/admin';
export default defineComponent({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@
</template>

<script lang="ts">
import Vue, { VueConstructor, PropType } from 'vue';
import type { VueConstructor, PropType } from 'vue';
import Vue from 'vue';
import { copy } from '@intake24/common/util';
import debounce from 'lodash/debounce';
import type { PromptQuestion } from '@intake24/common/prompts';
Expand Down
3 changes: 2 additions & 1 deletion apps/admin/src/components/prompts/list/prompt-list-item.vue
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@

<script lang="ts">
import isEqual from 'lodash/isEqual';
import { defineComponent, PropType } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import { copy } from '@intake24/common/util';
import type { PromptQuestion } from '@intake24/common/prompts';
import { ConfirmDialog } from '@intake24/ui';
Expand Down
3 changes: 2 additions & 1 deletion apps/admin/src/components/prompts/list/prompt-list.vue
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@

<script lang="ts">
import isEqual from 'lodash/isEqual';
import { defineComponent, PropType, ref } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent, ref } from '@vue/composition-api';
import draggable from 'vuedraggable';
import type { PromptQuestion } from '@intake24/common/prompts';
import type { SurveyQuestionSection, MealSection } from '@intake24/common/schemes';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@
</template>

<script lang="ts">
import Vue, { VueConstructor, PropType } from 'vue';
import type { VueConstructor, PropType } from 'vue';
import Vue from 'vue';
import pick from 'lodash/pick';
import { mapActions } from 'pinia';
import { copy } from '@intake24/common/util';
Expand Down
3 changes: 2 additions & 1 deletion apps/admin/src/components/prompts/partials/base-prompt.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { defineComponent, PropType } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import type { Condition, PromptValidationProps } from '@intake24/common/prompts';
import type { LocaleTranslation } from '@intake24/common/types';
import PromptContent from './prompt-content.vue';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,12 @@
</template>

<script lang="ts">
import { defineComponent, PropType } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import { copy, merge } from '@intake24/common/util';
import draggable from 'vuedraggable';
import { Condition, ConditionOp, conditionOps } from '@intake24/common/prompts';
import type { Condition, ConditionOp } from '@intake24/common/prompts';
import { conditionOps } from '@intake24/common/prompts';
import PromptAnswerProps from '@intake24/admin/components/prompts/partials/conditions/prompt-answer-props.vue';
import RecallNumberProps from '@intake24/admin/components/prompts/partials/conditions/recall-number-props.vue';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@
</template>

<script lang="ts">
import { defineComponent, PropType } from '@vue/composition-api';
import type { PropType } from '@vue/composition-api';
import { defineComponent } from '@vue/composition-api';
import type { LocaleTranslation } from '@intake24/common/types';
import { tinymce } from '@intake24/admin/components/tinymce';
import { LanguageSelector } from '@intake24/admin/components/forms';
Expand Down

0 comments on commit 65466e9

Please sign in to comment.