-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prisma #1031
Merged
Merged
Update prisma #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riron
force-pushed
the
mod/prisma-update
branch
4 times, most recently
from
October 19, 2021 07:51
b7fb886
to
6335163
Compare
zhouzi
approved these changes
Nov 4, 2021
providenz
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le front compile pas chez moi, après un generate ça passe.
Riron
force-pushed
the
mod/prisma-update
branch
from
November 8, 2021 10:00
6964cc1
to
0759e06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAJ Prisma - version 3.x qui permettait les gains de perf important, mais posait problème dans les tests d'inté.
Ils ont manifestement des fuites mémoires avec le nouvel API (cf prisma/prisma#8989): la connexion n'est jamais vraiment nettoyée car elle peut être réutilisée. Ca ne pose pas de problème en prod, mais comme jest recrée tout le contexte pour chaque test suite on a une fuite mémoire qui apparait. Ils réflechissent à ajouter une méthode à utiliser dans les tests type
$dispose
pour faire le ménage.En attendant, on contourne le problème en splittant les tests dans plusieurs runners (4 pour le moment) => moins de tests, donc pas le temps de memory overload !
En bonus on gagne du temps sur le run. En malus, c'est un peu moins clair à lire dans les github actions.
Suite à la montée de version, Prisma a changé sa manière de gérer les champs nullable pour les champs Json. On ne peut plus utiliser
null
. A la place il faut utilisePrisma.DbNull
ouPrisma.JsonNull
. En lecture et en écriture. Ca complique les cas ou on faisait lecture du champ -> écriture, notamment pour la duplication de formulaires.Pour "simplifier", j'ai passé les champs JSON en non nullable et valeur
[]
par défaut. Ce sont uniquement des packagingInfos, donc j'ai tendance à dire que la différencenull | []
a peu d'importance - mais ça peut se discuter !