Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreamableQuery parity #157

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kalafus
Copy link
Contributor

@kalafus kalafus commented Feb 5, 2024

make StreamableQuery symmetrically convert ChatQuery objects to non-streamable mode on the fly

What

ChatQuery initialized with stream = true can be used in .chats

Why

parity with non-streamable StreamableQuery being made streamable as needed.

Affected Areas

ChatQuery

Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
1.0% Duplication on New Code

See analysis details on SonarCloud

@kalafus
Copy link
Contributor Author

kalafus commented Feb 16, 2024

as it stands, the presumption is that ChatQuery will be created as non-streamable, and needs be made streamable on-demand. could also, for example, take away the stream parameter at ChatQuery initialization. that might make more sense, as the stream parameter is perfunctory if it is being changed as needed.

another option could be to eliminate both the default to stream: false as well as the whole concept of the Streamable protocol. at present, setting stream to false is an illusion -- there is no such thing in this API, seeing as a new struct is created with stream: true whenever needed.

thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant