Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSLDelegateProtocol to StreamingSession #191

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

batanus
Copy link

@batanus batanus commented Apr 2, 2024

What

Add SSLDelegateProtocol delegate to StreamingSession

Why

I've discovered that when initializing OpenAI class with URLSession, it isn't utilized if the request uses StreamingSession (which is logical). Consequently, if a client wishes to implement SSL Pinning in their application and passes their URLSession with a set delegate (which implements the didReceive challenge: URLAuthenticationChallenge method from URLSessionDelegate), URLSessionDelegate methods will be invoked only for requests that don't use StreamingSession and the streaming mechanism.

This PR introduces a mechanism that allows the user to pass their delegate inherited from SSLDelegateProtocol and manually handle didReceive challenge: URLAuthenticationChallenge.

Affected Areas

OpenAI and StreamingSession classes initializers

Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant