Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add a url parameter for chatsStream() #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tisfeng
Copy link

@tisfeng tisfeng commented May 11, 2024

What

Add a new publick API

    public func chatsStream(query: ChatQuery, url: URL, onResult: @escaping (Result<ChatStreamResult, Error>) -> Void, completion: ((Error?) -> Void)?) {
        performStreamingRequest(request: JSONRequest<ChatStreamResult>(body: query.makeStreamable(), url: url), onResult: onResult, completion: completion)
    }

Why

The current URL construction API is quite ugly and not convenient for supporting user-defined URLs, such as supporting non-HTTPS. I hope to use the API simply like this:

openAI.chatsStream(query: query, url:"http://localhost:11434/v1/chat/completions")

Affected Areas

None, just added a new API.

Copy link

sonarcloud bot commented May 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant