Skip to content
This repository has been archived by the owner on Mar 7, 2023. It is now read-only.

Remove outdated Node builds #134

Closed
wants to merge 5 commits into from
Closed

Conversation

MadLittleMods
Copy link
Owner

@MadLittleMods MadLittleMods commented Mar 17, 2021

Remove outdated Node builds

Fix #140


It appears like the Travis builds have been failing on tagged releases since 4.8.0, https://travis-ci.org/github/MadLittleMods/node-usb-detection/jobs/678826650 but there are still prebuild artifacts since then so I'm not sure.

And same error as today:

gyp: name 'v8_enable_pointer_compression' is not defined while evaluating condition 'v8_enable_pointer_compression == 1' in binding.gyp while trying to load binding.gyp

…gged release builds

Try fix from node-ffi-napi/node-ffi-napi@0d1de61

Error:
```
gyp: name 'v8_enable_pointer_compression' is not defined while evaluating condition 'v8_enable_pointer_compression == 1' in binding.gyp while trying to load binding.gyp
```
@mcous
Copy link
Contributor

mcous commented Sep 20, 2021

I've been digging into this some more, and I have a question and an idea:

  • How are the prebuilt assets uploaded? I can't figure out how prebuild --upload gets called
  • Both the Travis matrix and the AppVeryor matrix are set up to call prebuild --all on every singe build in the matrix, but I'm pretty sure this is unnecesary
    • Based on local testing, I think only one call to prebuild --all is required per OS/arch
    • e.g. only call prebuild --all on Node v14, and it'll generate assets for previous ABI's, too

On top of that, travis-ci.org has been deprecated in favor of travis-ci.com, so that needs to be figured out

@MadLittleMods
Copy link
Owner Author

@mcous Feel free to simplify and rip out the old way builds were working to make it sane.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub release URL not found when installing - prebuild
2 participants