Fixbuild #1
Closed
Fixbuild #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Including all tailwind styles as an inline style in every component could cause performance issues that a link would not due to browser caching. I think a better solution would be to have the link target a bundled css document when built with rollup. |
|
Solved by #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for your great Lit-Tailwind integration solution!
I found that it won't apply Tailwind styles in built web app. That's because Vite doesn't help compile
../styles/main.csswhen building. Thus, only the base64 encoded@import url(./tailwind.css);@import url(./global.css);stays in the<head>, which is definitely not working.According to this doc, I found that the only way to build this css file is to import it as a module. In this way, the compiled css can be appended in .