Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Electron 6: #1892

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Commits on Jan 20, 2020

  1. Upgrade to Electron 6:

    New version of Electron has enable by default sandbox
    http://www.atom.pe/docs/api/sandbox-option/
    
    There was some issues to migrate a new version of Electron for
    MagicMirror. Using the new version in Travis CI was failing at this
    time. The problem is because the testing runner is a Docker enviroment
    
    The issue experimented is the same topic mentioned here:
     - electron/electron#17972
     - electron-userland/spectron#443
    
    The fix for to all of this is to set the `--no-sandbox` mode in CI
    testing https://electronjs.org/docs/all#--no-sandbox
    
    This change use the feature to set and disable Sandbox using
    by enviroment variable `ELECTRON_DISABLE_SANDBOX=1`
    electron/electron#16576
    
    This change has reference MagicMirrorOrg#1800
    roramirez committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    a7ee2ef View commit details
    Browse the repository at this point in the history