Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/3456/update mcc naming #3606

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix/3456/update mcc naming #3606

wants to merge 6 commits into from

Conversation

Nereboss
Copy link
Collaborator

@Nereboss Nereboss commented Apr 30, 2024

Update MCC naming

Closes: #3456

Description

Temporarily adds 'formerly mcc' to the no longer renamed sonar complexity

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

@phanlezz
Copy link
Collaborator

phanlezz commented May 2, 2024

We need to investigate how this change will impact our online demo.

@phanlezz phanlezz force-pushed the fix/3456/update-mcc-naming branch from a292da5 to bf35d19 Compare May 6, 2024 08:28
@phanlezz
Copy link
Collaborator

phanlezz commented May 6, 2024

I rebased the branch to include the main changes

@phanlezz
Copy link
Collaborator

phanlezz commented May 6, 2024

I did some testing and here are some points that I found. We should evaluate if those changes are acceptable:

  • the current metric of the web demo can't be found, uses sonar_cognitive_complexity in local testing -> adjust link
  • "Metric Templates" are not applicable anymore (contain mcc)
  • "Suspicious Metrics" - MCC does not get detected as a preset
  • Attribute Descriptor Title for the sonar import still state "Maximum ...". We should change that.

@Nereboss
Copy link
Collaborator Author

Nereboss commented May 7, 2024

I think all these points should be addressed before merging this issue.

i further found that we include other metrics that talk about mcc (the sourceMonitor has max_function_mcc and average_function_mcc) that should be changed as well here.

@Nereboss Nereboss force-pushed the fix/3456/update-mcc-naming branch from bf35d19 to a5a90c4 Compare May 28, 2024 13:09
Nereboss added a commit that referenced this pull request May 28, 2024
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Nereboss added a commit that referenced this pull request May 29, 2024
@Nereboss Nereboss force-pushed the fix/3456/update-mcc-naming branch from a3411d2 to 5ec6f26 Compare June 4, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MCC name is incorrect
2 participants